x/auth: remove alias.go usage #6440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dauTT
requested review from
aaronc,
alessio,
alexanderbez,
clevinson,
fedekunze and
jgimeno
as code owners
tac0turtle
approved these changes
Jun 15, 2020
tac0turtle
added
the
A:automerge
Codecov Report
@@ Coverage Diff @@
## master #6440 +/- ##
=======================================
Coverage 55.98% 55.98%
=======================================
Files 466 466
Lines 27908 27908
=======================================
Hits 15623 15623
Misses 11180 11180
Partials 1105 1105 |
|
I am not sure how we should fix the
|
|
As a side note, the integrations tests are passing in github but locally they are failing. How can someone make sure that they are passing locally? |
you can add |
hmm this is odd. I tested out locally and they passed. Im not sure if its a env thing but this is a bit concerning |
colin-axner
previously requested changes
Jun 16, 2020
fedekunze
approved these changes
Jun 16, 2020
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
* x/auth: remove alias.go usage * Fix simd_test.go and formatting * Fix app.go formatting * Fix cli_test.go * Fix lint warnings * Undo accidental deletion during merge Co-authored-by: colin axner <[email protected]> Co-authored-by: Federico Kunze <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR closes a sub task in #6311
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorer