Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/evidence: remove alias.go usage #6435

Merged
merged 2 commits into from
Jun 14, 2020
Merged

x/evidence: remove alias.go usage #6435

merged 2 commits into from
Jun 14, 2020

Conversation

dauTT
Copy link
Contributor

@dauTT dauTT commented Jun 13, 2020

Description

This PR closes a sub task in #6311

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@codecov
Copy link

codecov bot commented Jun 13, 2020 •
edited
Loading

Codecov Report

Merging #6435 into master will not change coverage.
The diff coverage is 69.69%.

@@           Coverage Diff           @@
##           master    #6435   +/-   ##
=======================================
  Coverage   55.72%   55.72%           
=======================================
  Files         465      465           
  Lines       27782    27782           
=======================================
  Hits        15481    15481           
  Misses      11197    11197           
  Partials     1104     1104

@dauTT dauTT mentioned this pull request Jun 13, 2020
Closed
4 tasks
tac0turtle
tac0turtle approved these changes Jun 13, 2020
View reviewed changes
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

loving these!! thank you

@alexanderbez alexanderbez added R4R C:x/evidence A:automerge Automatically merge PR once all prerequisites pass. labels Jun 13, 2020
alexanderbez
alexanderbez approved these changes Jun 13, 2020
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@tac0turtle tac0turtle merged commit cc42a82 into cosmos:master Jun 14, 2020
@dauTT dauTT deleted the remove-alias-x-evidence branch June 14, 2020 10:34
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
@dauTT
x/evidence: remove alias.go usage (cosmos#6435)
61c12df
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderbez alexanderbez alexanderbez approved these changes

@tac0turtle tac0turtle tac0turtle approved these changes

@aaronc aaronc Awaiting requested review from aaronc

@alessio alessio Awaiting requested review from alessio

@clevinson clevinson Awaiting requested review from clevinson

@fedekunze fedekunze Awaiting requested review from fedekunze

@jgimeno jgimeno Awaiting requested review from jgimeno

Assignees
No one assigned
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/evidence
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dauTT @alexanderbez @tac0turtle