Convert simple proof to ics23 proof #6390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdityaSripal
requested review from
aaronc,
alessio,
alexanderbez,
clevinson,
fedekunze and
jgimeno
as code owners
Codecov Report
@@ Coverage Diff @@
## master #6390 +/- ##
==========================================
- Coverage 55.60% 51.33% -4.27%
==========================================
Files 457 303 -154
Lines 27440 17098 -10342
==========================================
- Hits 15257 8778 -6479
+ Misses 11083 7738 -3345
+ Partials 1100 582 -518 |
AdityaSripal
commented
Jun 10, 2020
| @@ -109,36 +109,6 @@ func TestVerifyMultiStoreQueryProof(t *testing.T) { | |||
| require.NotNil(t, err) | |||
| } | |||
|
|
|||
| func TestVerifyMultiStoreQueryProofEmptyStore(t *testing.T) { | |||
There was a problem hiding this comment.
Note proofs of empty stores no longer supported. Is this something we need?
There was a problem hiding this comment.
Not for IBC at least. Maybe useful for some other application use-case?
cwgoes
approved these changes
Jun 10, 2020
| @@ -109,36 +109,6 @@ func TestVerifyMultiStoreQueryProof(t *testing.T) { | |||
| require.NotNil(t, err) | |||
| } | |||
|
|
|||
| func TestVerifyMultiStoreQueryProofEmptyStore(t *testing.T) { | |||
There was a problem hiding this comment.
Not for IBC at least. Maybe useful for some other application use-case?
This was referenced Jun 15, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simple PR that builds off work in #6323
Converts the SimpleProof in rootmultistore to
ics23.CommitmentProofProofRuntime now relies solely on CommitmentProof
closes: #5842
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorer