x/upgrade: remove alias.go usage #6382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dauTT
requested review from
aaronc,
alessio,
alexanderbez,
clevinson,
fedekunze and
jgimeno
as code owners
Codecov Report
@@ Coverage Diff @@
## master #6382 +/- ##
==========================================
+ Coverage 47.95% 55.50% +7.55%
==========================================
Files 216 465 +249
Lines 11836 27536 +15700
==========================================
+ Hits 5676 15284 +9608
- Misses 5758 11154 +5396
- Partials 402 1098 +696 |
alexanderbez
approved these changes
Jun 10, 2020
alexanderbez
added
the
A:automerge
fedekunze
suggested changes
Jun 10, 2020
x/upgrade/abci_test.go
Outdated
Comment on lines
25
to
26
| upgradekeeper "github.com/cosmos/cosmos-sdk/x/upgrade/keeper" | ||
| upgradetypes "github.com/cosmos/cosmos-sdk/x/upgrade/types" |
There was a problem hiding this comment.
When you are on the same module (i.e x/upgrade in this case) you don't need to define the imported packages with the upgrade... prefix
Suggested change
| upgradekeeper "github.com/cosmos/cosmos-sdk/x/upgrade/keeper" | |
| upgradetypes "github.com/cosmos/cosmos-sdk/x/upgrade/types" | |
| "github.com/cosmos/cosmos-sdk/x/upgrade/keeper" | |
| "github.com/cosmos/cosmos-sdk/x/upgrade/types" |
fedekunze
approved these changes
Jun 10, 2020
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
* x/upgrade: remove alias.go usage * Simplify code Co-authored-by: Alexander Bezobchuk <[email protected]> Co-authored-by: Federico Kunze <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR closes a sub task in #6311
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorer