Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/distribution: register MsgFundCommunityPool #6211

Merged
merged 2 commits into from
May 13, 2020

Conversation

fedekunze
Copy link
Collaborator

Description

closes: #6210

@auto-comment
Copy link

auto-comment bot commented May 13, 2020

👋 Thanks for creating a PR!

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Thank you for your contribution to the Cosmos-SDK! 🚀

@alexanderbez alexanderbez mentioned this pull request May 13, 2020
6 tasks
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@codecov
Copy link

codecov bot commented May 13, 2020

Codecov Report

Merging #6211 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #6211   +/-   ##
=======================================
  Coverage   54.86%   54.86%           
=======================================
  Files         444      444           
  Lines       26787    26788    +1     
=======================================
+ Hits        14697    14698    +1     
  Misses      11048    11048           
  Partials     1042     1042           

@fedekunze fedekunze added the A:automerge Automatically merge PR once all prerequisites pass. label May 13, 2020
@fedekunze fedekunze merged commit 6d7fc91 into master May 13, 2020
@fedekunze fedekunze deleted the fedekunze/6210-fix-fund-community-pool branch May 13, 2020 16:14
@alexanderbez alexanderbez added the T: State Machine Breaking State machine breaking changes (impacts consensus). label May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/distribution distribution module related T:Bug T: State Machine Breaking State machine breaking changes (impacts consensus).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panic: Cannot encode unregistered concrete type types.MsgFundCommunityPool.
2 participants