Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auth: make sign command accept multiple input files #6208

Closed
wants to merge 11 commits into from

Conversation

alessio
Copy link
Contributor

@alessio alessio commented May 13, 2020

No description provided.

@alessio alessio added the WIP label May 13, 2020
@auto-comment
Copy link

auto-comment bot commented May 13, 2020

👋 Thanks for creating a PR!

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Thank you for your contribution to the Cosmos-SDK! 🚀

@codecov
Copy link

codecov bot commented May 13, 2020

Codecov Report

Merging #6208 into master will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #6208      +/-   ##
==========================================
- Coverage   54.75%   54.73%   -0.02%     
==========================================
  Files         447      447              
  Lines       26894    26902       +8     
==========================================
  Hits        14726    14726              
- Misses      11124    11132       +8     
  Partials     1044     1044              

x/auth/client/cli/tx_sign.go Outdated Show resolved Hide resolved
@alessio alessio marked this pull request as ready for review May 13, 2020 22:32
@alessio alessio added R4R C:CLI and removed WIP labels May 13, 2020
Copy link
Member

@aaronc aaronc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alessio would you be able to add a cli_test that reads multiple files?

x/auth/client/cli/tx_sign.go Outdated Show resolved Hide resolved
@alessio alessio added WIP and removed R4R labels May 14, 2020
@alessio
Copy link
Contributor Author

alessio commented May 14, 2020

will do @aaronc

@alessio alessio added R4R and removed WIP labels May 17, 2020
@alessio alessio requested a review from aaronc May 17, 2020 21:45
@alessio
Copy link
Contributor Author

alessio commented Jun 5, 2020

Abandoned in favor of #6350

@alessio alessio closed this Jun 5, 2020
@alessio alessio deleted the alessio/sign-batch branch June 5, 2020 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants