-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proto Any init + evidence #6076
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
aaronc
added
the
T: Proto Breaking
Protobuf breaking changes: never don't do this!
label
Apr 30, 2020
alexanderbez
reviewed
May 1, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few minor bits of feedback, but otherwise LGTM
Co-authored-by: Alexander Bezobchuk <[email protected]>
Co-authored-by: Alexander Bezobchuk <[email protected]>
Co-authored-by: Alexander Bezobchuk <[email protected]>
Co-authored-by: Alexander Bezobchuk <[email protected]>
Co-authored-by: Alexander Bezobchuk <[email protected]>
Co-authored-by: Alexander Bezobchuk <[email protected]>
alexanderbez
approved these changes
May 1, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
alexanderbez
added
the
A:automerge
Automatically merge PR once all prerequisites pass.
label
May 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A:automerge
Automatically merge PR once all prerequisites pass.
T: Dev UX
UX for SDK developers (i.e. how to call our code)
T: Proto Breaking
Protobuf breaking changes: never don't do this!
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements initial protobuf
Any
code plus migratesx/evidence
as described in the updated version of ADR 019 (#6081).Details
codec/types
package with:Any
InterfaceRegistry
+UnpackInterfacesMessage
MarshalAny
,UnmarshalAny
InterfaceModule
totypes/module
AppCodec
andMakeCodecs
helper fn's to simappx/evidence
to useAny
with examples of marshaling/unmarshalingAny
+UnpackInterfacesMessage
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)