Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proto Any init + evidence #6076

Merged
merged 52 commits into from
May 5, 2020
Merged

Proto Any init + evidence #6076

merged 52 commits into from
May 5, 2020

Conversation

aaronc
Copy link
Member

@aaronc aaronc commented Apr 24, 2020

Summary

Implements initial protobuf Any code plus migrates x/evidence as described in the updated version of ADR 019 (#6081).

Details

  • Creates codec/types package with:
    • custom implementation of Any
    • InterfaceRegistry + UnpackInterfacesMessage
    • helper functions MarshalAny, UnmarshalAny
  • Adds InterfaceModule to types/module
  • Adds AppCodec and MakeCodecs helper fn's to simapp
  • Migrates x/evidence to use Any with examples of marshaling/unmarshaling Any + UnpackInterfacesMessage

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@aaronc aaronc changed the title Proto any init + evidence Proto Any init + evidence Apr 24, 2020
codec/std/codec.go Outdated Show resolved Hide resolved
codec/types/any.go Show resolved Hide resolved
codec/types/any.go Outdated Show resolved Hide resolved
codec/types/any.go Outdated Show resolved Hide resolved
codec/types/any.go Outdated Show resolved Hide resolved
codec/types/any.go Outdated Show resolved Hide resolved
codec/types/any.go Outdated Show resolved Hide resolved
codec/types/any.go Show resolved Hide resolved
codec/types/any.go Show resolved Hide resolved
codec/types/interface_registry.go Show resolved Hide resolved
codec/types/interface_registry.go Show resolved Hide resolved
@aaronc aaronc added the T: Proto Breaking Protobuf breaking changes: never don't do this! label Apr 30, 2020
@aaronc aaronc added the T: Dev UX UX for SDK developers (i.e. how to call our code) label Apr 30, 2020
x/evidence/types/msgs.go Outdated Show resolved Hide resolved
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few minor bits of feedback, but otherwise LGTM

codec/types/any.go Outdated Show resolved Hide resolved
codec/types/any.go Outdated Show resolved Hide resolved
codec/types/interface_registry.go Outdated Show resolved Hide resolved
x/evidence/simulation/decoder.go Show resolved Hide resolved
x/evidence/types/codec.go Outdated Show resolved Hide resolved
x/evidence/types/codec.go Outdated Show resolved Hide resolved
x/evidence/types/codec.go Outdated Show resolved Hide resolved
x/evidence/types/msgs.go Show resolved Hide resolved
aaronc and others added 7 commits May 1, 2020 15:57
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@alexanderbez alexanderbez requested a review from clevinson as a code owner May 2, 2020 15:11
@alexanderbez alexanderbez added the A:automerge Automatically merge PR once all prerequisites pass. label May 2, 2020
@clevinson clevinson added this to the v0.39 milestone May 4, 2020
@fedekunze fedekunze mentioned this pull request May 5, 2020
11 tasks
@alexanderbez alexanderbez merged commit 3862172 into master May 5, 2020
@alexanderbez alexanderbez deleted the aaronc/proto-any-init branch May 5, 2020 14:28
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. T: Dev UX UX for SDK developers (i.e. how to call our code) T: Proto Breaking Protobuf breaking changes: never don't do this!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants