Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GRPC querier init and bank #5953

Closed
wants to merge 52 commits into from
Closed

Conversation

aaronc
Copy link
Member

@aaronc aaronc commented Apr 8, 2020

ref: #5921

Initial scaffolding for GRPC queries as specified in ADR 021 (#5894) plus x/bank migration as an example case.

Replaces #5882.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@aaronc aaronc mentioned this pull request Apr 8, 2020
11 tasks
types/router.go Outdated Show resolved Hide resolved
x/bank/keeper/querier.go Show resolved Hide resolved
baseapp/queryrouter.go Outdated Show resolved Hide resolved
x/mint/module.go Outdated Show resolved Hide resolved
x/auth/module.go Outdated Show resolved Hide resolved
x/supply/module.go Outdated Show resolved Hide resolved
x/bank/module.go Outdated Show resolved Hide resolved
x/gov/module.go Outdated Show resolved Hide resolved
x/staking/module.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 8, 2020

Codecov Report

Merging #5953 into master will decrease coverage by 4.79%.
The diff coverage is 28.57%.

@@            Coverage Diff             @@
##           master    #5953      +/-   ##
==========================================
- Coverage   55.70%   50.90%   -4.80%     
==========================================
  Files         446      189     -257     
  Lines       26934    11656   -15278     
==========================================
- Hits        15004     5934    -9070     
+ Misses      10859     5335    -5524     
+ Partials     1071      387     -684     

x/slashing/module.go Outdated Show resolved Hide resolved
x/distribution/module.go Outdated Show resolved Hide resolved
x/bank/client/cli/query.go Outdated Show resolved Hide resolved
client/context/query.go Outdated Show resolved Hide resolved
baseapp/queryrouter.go Outdated Show resolved Hide resolved
baseapp/queryrouter.go Outdated Show resolved Hide resolved
baseapp/queryrouter.go Outdated Show resolved Hide resolved
baseapp/queryrouter.go Outdated Show resolved Hide resolved
client/context/query.go Outdated Show resolved Hide resolved
@aaronc aaronc marked this pull request as draft April 27, 2020 14:40
@clevinson clevinson linked an issue Apr 30, 2020 that may be closed by this pull request
43 tasks
@clevinson clevinson added this to the v0.39 milestone Apr 30, 2020
This was referenced May 14, 2020
@aaronc
Copy link
Member Author

aaronc commented Jun 10, 2020

Replaced by #6325, #6326, #6335, #6336, #6342, #6343, #6353, and #6367.

@aaronc aaronc closed this Jun 10, 2020
@alessio alessio deleted the aaronc/grpc-querier-bank-init branch March 14, 2021 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query Protobuf Migration
4 participants