Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/crisis: Proto Tx CLI Command #5916

Merged
merged 2 commits into from
Apr 2, 2020
Merged

x/crisis: Proto Tx CLI Command #5916

merged 2 commits into from
Apr 2, 2020

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Apr 2, 2020 •
edited
Loading

ref: #5864

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alexanderbez alexanderbez mentioned this pull request Apr 2, 2020
Closed
15 tasks
fedekunze
fedekunze approved these changes Apr 2, 2020
View reviewed changes
x/crisis/client/cli/tx.go
@@ -52,3 +75,24 @@ func GetTxCmd(cdc *codec.Codec) *cobra.Command {
)...)
return txCmd
}

// command to replace a delegator's withdrawal address
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is from distr

Copy link
Contributor Author

@alexanderbez alexanderbez Apr 2, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Must've been missed in the original PR. I'll remove 👍

aaronc
aaronc approved these changes Apr 2, 2020
View reviewed changes
Copy link
Member

@aaronc aaronc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than Fede's doc comment, LGTM.

@alexanderbez alexanderbez merged commit e0c1774 into master Apr 2, 2020
@alexanderbez alexanderbez deleted the bez/5864-x-crisis-mod branch April 2, 2020 19:07
aaronc
aaronc reviewed Apr 8, 2020
View reviewed changes
x/crisis/client/cli/tx.go
inBuf := bufio.NewReader(cmd.InOrStdin())
txBldr := auth.NewTxBuilderFromCLI(inBuf).WithTxEncoder(authclient.GetTxEncoder(cdc))
cliCtx := context.NewCLIContextWithInput(inBuf).WithCodec(cdc)
cliCtx := context.NewCLIContextWithInputAndFrom(inBuf, args[0]).WithMarshaler(m)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be NewCLIContextWithInput because args[0] is a module-name not an address.

@clevinson clevinson added this to the v0.39 milestone May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronc aaronc aaronc approved these changes

@fedekunze fedekunze fedekunze approved these changes

@alessio alessio Awaiting requested review from alessio

@hschoenburg hschoenburg Awaiting requested review from hschoenburg

@nylira nylira Awaiting requested review from nylira

@tac0turtle tac0turtle Awaiting requested review from tac0turtle

Assignees
No one assigned
Labels
C:x/crisis
Projects
None yet
Milestone
v0.40 [Stargate]
Development

Successfully merging this pull request may close these issues.
4 participants
@alexanderbez @aaronc @fedekunze @clevinson