-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
patch auth register cdc #5892
Merged
Merged
patch auth register cdc #5892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedekunze
requested review from
alessio,
alexanderbez,
hschoenburg and
nylira
as code owners
March 30, 2020 15:25
alexanderbez
suggested changes
Mar 30, 2020
…m/cosmos/cosmos-sdk into fedekunze/patch-auth-register-cdc
alexanderbez
approved these changes
Mar 30, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fedekunze
added
the
A:automerge
Automatically merge PR once all prerequisites pass.
label
Mar 30, 2020
Codecov Report
@@ Coverage Diff @@
## master #5892 +/- ##
==========================================
- Coverage 56.82% 56.80% -0.02%
==========================================
Files 342 342
Lines 20044 20046 +2
==========================================
- Hits 11389 11388 -1
- Misses 7805 7808 +3
Partials 850 850 |
jgimeno
approved these changes
Mar 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: Chainsafe/ethermint#235
Description
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)