-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement --offline flag #5810
implement --offline flag #5810
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5810 +/- ##
=========================================
- Coverage 32.51% 32.3% -0.21%
=========================================
Files 346 353 +7
Lines 39012 39461 +449
=========================================
+ Hits 12684 12749 +65
- Misses 25061 25439 +378
- Partials 1267 1273 +6
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good start! I'd love some test cases - at least to avoid code coverage to get even lower. Plus, all query commands should all fail if --offline
is passed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @jgimeno! Let's get a branch open against Gaia that tests this out.
Co-Authored-By: Alexander Bezobchuk <[email protected]>
Co-Authored-By: Alexander Bezobchuk <[email protected]>
Co-Authored-By: Alexander Bezobchuk <[email protected]>
…m:cosmos/cosmos-sdk into jonathan/5448-split-generate-only-offline
Here is the branch using this changes cosmos/gaia#326 |
FTR @jgimeno and I are testing the changes with |
Please merge when thorough testing has been performed @alessio. |
…m:cosmos/cosmos-sdk into jonathan/5448-split-generate-only-offline
Manual testing passed. We're now investigating into the drop of coverage stats. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor thing left, otherwise this is good to go
Dismissing review as per #5810 (comment)
Closes: #5448
Description
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)