-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix x/genutil ExportGenesis #5775
Conversation
func (am AppModule) ExportGenesis(_ sdk.Context, _ codec.JSONMarshaler) json.RawMessage { | ||
return nil | ||
func (am AppModule) ExportGenesis(_ sdk.Context, cdc codec.JSONMarshaler) json.RawMessage { | ||
return am.DefaultGenesis(cdc) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't ExportGenesis
return the list of GenTxs if exists, instead of the default state?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, since this is for exporting state. In other words, we already have initiated and bootstrapped the chain, so we don't need genesis txs to do so.
Codecov Report
@@ Coverage Diff @@
## master #5775 +/- ##
=======================================
Coverage 35.91% 35.91%
=======================================
Files 341 341
Lines 34745 34745
=======================================
Hits 12478 12478
Misses 21023 21023
Partials 1244 1244
|
Closes: #5765
Description
Fix
x/genutil
ExportGenesis
as to not return null, but instead default genesis state ([]
), so on export, genesis validation should pass.For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)