Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Gov module to Simapp #5738

Merged
merged 25 commits into from
Mar 2, 2020
Merged

Conversation

jgimeno
Copy link
Contributor

@jgimeno jgimeno commented Mar 2, 2020

Closes: #4875

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alexanderbez alexanderbez mentioned this pull request Mar 2, 2020
14 tasks
@jgimeno jgimeno marked this pull request as ready for review March 2, 2020 18:58
@jgimeno jgimeno added R4R and removed WIP labels Mar 2, 2020
@alexanderbez alexanderbez added the A:automerge Automatically merge PR once all prerequisites pass. label Mar 2, 2020
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK -- great job @jgimeno

@alexanderbez alexanderbez merged commit e45feae into master Mar 2, 2020
@alexanderbez alexanderbez deleted the jonathan/4875-gov-use-simapp branch March 2, 2020 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/gov T: Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate x/mock, transition integration tests to use simapp
2 participants