Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track proposal handler events on success #5622

Merged
merged 4 commits into from
Feb 6, 2020

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Feb 6, 2020

Description

Track any events emitted from a proposal's handler upon successful execution.

closes: #5616


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

This was referenced Feb 6, 2020
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexanderbez alexanderbez merged commit cd9b2d4 into master Feb 6, 2020
@alexanderbez alexanderbez deleted the bez/5616-fix-prop-hndlr-events branch February 6, 2020 21:19
@codecov
Copy link

codecov bot commented Feb 6, 2020

Codecov Report

Merging #5622 into master will decrease coverage by 8.9%.
The diff coverage is 27.4%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5622      +/-   ##
==========================================
- Coverage   53.43%   44.52%   -8.91%     
==========================================
  Files         322      324       +2     
  Lines       19751    24701    +4950     
==========================================
+ Hits        10553    10998     +445     
- Misses       8381    12643    +4262     
- Partials      817     1060     +243
Impacted Files Coverage Δ
x/staking/types/types.pb.go 11.02% <ø> (ø)
codec/codec.go 100% <ø> (ø) ⬆️
x/staking/client/cli/query.go 0% <0%> (ø) ⬆️
types/int.go 69.68% <0%> (-0.75%) ⬇️
types/decimal.go 73.07% <0%> (-0.41%) ⬇️
codec/amino.go 45.83% <0%> (ø) ⬆️
types/staking.go 0% <0%> (ø) ⬆️
types/types.pb.go 6.02% <0.81%> (-5.03%) ⬇️
x/staking/keeper/params.go 100% <100%> (ø) ⬆️
x/staking/keeper/query_utils.go 83.87% <100%> (+0.26%) ⬆️
... and 21 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gov Proposal Handler - Events Are Not Tracked
2 participants