Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client and types additions for IBC #5585

Merged
merged 6 commits into from
Jan 30, 2020
Merged

client and types additions for IBC #5585

merged 6 commits into from
Jan 30, 2020

Conversation

fedekunze
Copy link
Collaborator

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

types/rest/rest.go Outdated Show resolved Hide resolved
client/context/query.go Outdated Show resolved Hide resolved
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@alexanderbez alexanderbez merged commit 5a0a36a into master Jan 30, 2020
@alexanderbez alexanderbez deleted the ibc-client-types branch January 30, 2020 15:13
@fedekunze fedekunze mentioned this pull request Jan 31, 2020
6 tasks
@alessio alessio mentioned this pull request Mar 10, 2020
11 tasks
@alessio alessio mentioned this pull request Jul 10, 2020
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants