Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Tendermint Version to v0.33.0 #5527

Merged
merged 13 commits into from
Jan 16, 2020
Merged

Bump Tendermint Version to v0.33.0 #5527

merged 13 commits into from
Jan 16, 2020

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Jan 15, 2020 •
edited
Loading

  • Bump Tendermint to v0.33.0
    • Replace all old tendermint/common packages with the new respective packages
    • Updates to reflect API changes to tm-db
  • Bump IAVL to v0.13.0
    • Updates to reflect API changes
  • Run goimports on codebase

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alexanderbez alexanderbez added the S:blocked Status: Blocked label Jan 15, 2020
@alexanderbez
Copy link
Contributor Author

alexanderbez commented Jan 15, 2020 •
edited
Loading

All changes are complete I believe. Now, blocked on IAVL release...

This was referenced Jan 15, 2020
Closed
Closed
@alexanderbez alexanderbez removed the S:blocked Status: Blocked label Jan 16, 2020
@alexanderbez
Copy link
Contributor Author

Remaining updates needed:

Please add anything I'm missing @marbar3778

@jackzampolin jackzampolin mentioned this pull request Jan 16, 2020
Merged
17 tasks
@jackzampolin jackzampolin marked this pull request as ready for review January 16, 2020 20:27
@jackzampolin jackzampolin added dependencies Pull requests that update a dependency file and removed WIP labels Jan 16, 2020
@alexanderbez
Fix unit tests
31c9ab7
@alexanderbez
Merge remote-tracking branch 'refs/remotes/origin/bez/bump-tendermint…
a576678 
…-version'

Conflicts:
	crypto/encode_test.go
	store/cachekv/store_test.go
fedekunze
fedekunze approved these changes Jan 16, 2020
View reviewed changes
Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@jackzampolin jackzampolin merged commit c1991e3 into master Jan 16, 2020
@jackzampolin jackzampolin deleted the bez/bump-tendermint-version branch January 16, 2020 21:46
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
@alexanderbez @jackzampolin
Merge PR cosmos#5527: Bump Tendermint Version to v0.33.0
60ba5ff 
* Bump Tendermint version to v0.33.0

* Deprecate old cmn package with new packages

* Update update DB APIs

* More DB updates

* Bump IAVL to v0.13.0

* Handle error returned by iavl.NewMutableTree

* Fix some IAVL stuffs

* Update IAVL

* More updates

* Passing tests

* Fix unit tests

Co-authored-by: Jack Zampolin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackzampolin jackzampolin jackzampolin approved these changes

@fedekunze fedekunze fedekunze approved these changes

@alessio alessio Awaiting requested review from alessio

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

@tac0turtle tac0turtle Awaiting requested review from tac0turtle

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexanderbez @jackzampolin @fedekunze