-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
application interfaces for simulation #5378
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should discuss this strategy and goals first. I would rather not have legitimate applications to expose their underlying baseapp and store key references. If this means apps need to duplicate a bit of code, so be it.
👍 I will pass |
Codecov Report
@@ Coverage Diff @@
## master #5378 +/- ##
==========================================
- Coverage 54.79% 54.75% -0.05%
==========================================
Files 311 312 +1
Lines 18761 18789 +28
==========================================
+ Hits 10280 10287 +7
- Misses 7703 7724 +21
Partials 778 778
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for cleaning this up @fedekunze! Left some pretty minor comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK -- I see calls to SetupSimulation
where a logger
is created after. Why not use the logger
from the SetupSimulation
call?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
Description
This PR introduces app interfaces in order to simplify the creation of the simulation tests (like the ones defined in
/simapp/sim_test.go
) for SDK based chains.TODO:
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)