Fix IAVL Iterator Race Condition #5279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderbez
requested review from
alessio,
fedekunze,
jackzampolin and
rigelrozanski
as code owners
alexanderbez
commented
Nov 5, 2019
| func (iter *iavlIterator) Close() { | ||
| close(iter.quitCh) | ||
| // wait iterCh to close | ||
| for range iter.iterCh { |
There was a problem hiding this comment.
See comment in the original issue. I believe we can alternatively wait on a done channel that gets sent during iterateRoutine(). But I think this will also suffice.
In addition, not sure how to best test this as I imagine we'll need a large tree to have iterateRoutine still run after we call Close().
There was a problem hiding this comment.
Use go test -race in unit test may make this bug happen. But it does not always happen.
Codecov Report
@@ Coverage Diff @@
## master #5279 +/- ##
==========================================
- Coverage 53.5% 53.49% -0.01%
==========================================
Files 290 290
Lines 17770 17771 +1
==========================================
Hits 9507 9507
Misses 7513 7513
- Partials 750 751 +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #5276
credit: @wangkui0508 🎉
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added a relevant changelog entry to the
Unreleasedsection inCHANGELOG.mdRe-reviewed
Files changedin the github PR explorerFor Admin Use: