REVIEW: Change from glide to dep #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Whoa big move switching to dep - is there a discussion documented somewhere as to why we want to do this? If we're making this move we should also outline in the |
|
Will update tendermint coding. But I've put in pull requests across the entire tendermint/cosmos repository surface area and CI passes on all of them. Let's discuss during the next team meeting but my goal here was to provide proof that we could painlessly switch to dep from glide. |
|
cool let's do it |
Closed
facundomedica
pushed a commit
that referenced
this pull request
Apr 27, 2023
Co-authored-by: Matt Kocubinski <[email protected]> Co-authored-by: Marko <[email protected]> Co-authored-by: samricotta <[email protected]> Co-authored-by: Julien Robert <[email protected]>
MSalopek
pushed a commit
to MSalopek/cosmos-sdk
that referenced
this pull request
Feb 10, 2024
* ci * lints and remove some unnecessary CI jobs * update tests go mod * more lints * remove denom owners since not implemented in osmosis * more lints * fix test values * implement nolint again * more test fixes * add back labeler as v4 * remove tabs and slash * update json to const * move file locations * push * fix seq num issue * Update tests/e2e/auth/vesting/suite.go * add back pwd * remove sonarcloud --------- Co-authored-by: Matt, Park <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch Glide to dep for dependency resolution