Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return Height on Query Errors + Update Account Endpoint #4924

Merged
merged 4 commits into from
Aug 19, 2019

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Aug 19, 2019

  • Return response height even upon error as it may be useful for the downstream caller
  • Have /auth/accounts/{address} return a 200 with an empty account upon error when that error is that the account doesn't exist (a temporary precursor to Standardize API Responses/HTTP Codes #4923).

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Re-reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alexanderbez alexanderbez marked this pull request as ready for review August 19, 2019 14:01
@alexanderbez alexanderbez added R4R and removed WIP labels Aug 19, 2019
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚡️ LGTM

@codecov
Copy link

codecov bot commented Aug 19, 2019

Codecov Report

Merging #4924 into master will not change coverage.
The diff coverage is 50%.

@@           Coverage Diff           @@
##           master    #4924   +/-   ##
=======================================
  Coverage   53.74%   53.74%           
=======================================
  Files         272      272           
  Lines       17105    17105           
=======================================
  Hits         9193     9193           
  Misses       7221     7221           
  Partials      691      691

@alexanderbez alexanderbez merged commit 89b1220 into master Aug 19, 2019
@alexanderbez alexanderbez deleted the bez/include-height-no-acc-query branch August 19, 2019 14:58
@alexanderbez alexanderbez mentioned this pull request Aug 21, 2019
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants