Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix simapp black listed addr bug #4913

Merged
merged 2 commits into from
Aug 15, 2019
Merged

fix simapp black listed addr bug #4913

merged 2 commits into from
Aug 15, 2019

Conversation

colin-axner
Copy link
Contributor

@colin-axner colin-axner commented Aug 15, 2019 •
edited
Loading

fixes #4912

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Re-reviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

alexanderbez
alexanderbez approved these changes Aug 15, 2019
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@alexanderbez alexanderbez added R4R T: State Machine Breaking State machine breaking changes (impacts consensus). labels Aug 15, 2019
fedekunze
fedekunze approved these changes Aug 15, 2019
View reviewed changes
Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@alexanderbez alexanderbez merged commit bc170cb into master Aug 15, 2019
@alexanderbez alexanderbez deleted the colin/4912-blacklistedaddrs branch August 15, 2019 22:29
alexanderbez pushed a commit that referenced this pull request Aug 16, 2019
@colin-axner @alexanderbez
Merge PR #4913: Fix Module Account Blacklisting in SimApp
a6f265c
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
@colin-axner @alexanderbez
Merge PR cosmos#4913: Fix Module Account Blacklisting in SimApp
61f668a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderbez alexanderbez alexanderbez approved these changes

@AdityaSripal AdityaSripal AdityaSripal approved these changes

@fedekunze fedekunze fedekunze approved these changes

@alessio alessio Awaiting requested review from alessio

@jackzampolin jackzampolin Awaiting requested review from jackzampolin

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

Assignees
No one assigned
Labels
T: State Machine Breaking State machine breaking changes (impacts consensus).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ModuleAccountAddrs in SimApp cannot rely on supply keeper
4 participants
@colin-axner @alexanderbez @AdityaSripal @fedekunze