-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
print all failed invariants only #4832
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4832 +/- ##
=========================================
+ Coverage 54.2% 54.2% +<.01%
=========================================
Files 269 269
Lines 17189 17188 -1
=========================================
Hits 9317 9317
+ Misses 7182 7181 -1
Partials 690 690 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one tiny bit of feedback + lets also get a pending log entry 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
neither of the other invariants prs has a pending log, should I include references to them in the entry? I will do a entry for this change, but I can update it if you think it should have more info |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
fixes #4824
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/
)Added a relevant changelog entry:
clog add [section] [-t <tag>] [-m <msg>]
Re-reviewed
Files changed
in the github PR explorerFor Admin Use: