Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

print all failed invariants only #4832

Merged
merged 3 commits into from
Aug 5, 2019

Conversation

colin-axner
Copy link
Contributor

@colin-axner colin-axner commented Aug 1, 2019

fixes #4824

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: clog add [section] [-t <tag>] [-m <msg>]

  • Re-reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Aug 1, 2019

Codecov Report

Merging #4832 into master will increase coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #4832      +/-   ##
=========================================
+ Coverage    54.2%   54.2%   +<.01%     
=========================================
  Files         269     269              
  Lines       17189   17188       -1     
=========================================
  Hits         9317    9317              
+ Misses       7182    7181       -1     
  Partials      690     690

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one tiny bit of feedback + lets also get a pending log entry 👍

types/invariant.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@colin-axner
Copy link
Contributor Author

colin-axner commented Aug 2, 2019

Just one tiny bit of feedback + lets also get a pending log entry

neither of the other invariants prs has a pending log, should I include references to them in the entry? I will do a entry for this change, but I can update it if you think it should have more info

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@alexanderbez alexanderbez merged commit 865d473 into master Aug 5, 2019
@alexanderbez alexanderbez deleted the colin/4824-print-failed-invariants branch August 5, 2019 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Print only failed invariants
3 participants