Fix ledger custom coin type support bug #4716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yun-yeo
requested review from
alessio,
alexanderbez,
jackzampolin and
rigelrozanski
as code owners
Codecov Report
@@ Coverage Diff @@
## master #4716 +/- ##
==========================================
- Coverage 50.47% 50.46% -0.01%
==========================================
Files 288 288
Lines 18571 18572 +1
==========================================
Hits 9373 9373
- Misses 8509 8510 +1
Partials 689 689 |
fedekunze
added
C:Ledger
|
Would it be possible to add an additional test that uses this mock class with a different coin type and hrp? |
|
I would not say this is actually a bug but when custom coin types were added, it seems that tests where not extended to support them. It would be good to add test cases and test vectors too. It should be important to clarify, that originally this mock was done specifically for the current ledger nano app for cosmos. |
|
Bump |
|
@jleni I add some test code for the custom coin type. |
fedekunze
approved these changes
Jul 23, 2019
|
@fedekunze done |
alexanderbez
pushed a commit
that referenced
this pull request
Oct 30, 2019
alexanderbez
added a commit
that referenced
this pull request
Oct 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will fix custom hrp usage and ledger test bug for custom coin type project.
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added a relevant changelog entry:
clog add [section] [stanza] [message]rereviewed
Files changedin the github PR explorerFor Admin Use: