Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove debugdb & colors #4651

Merged
merged 4 commits into from
Jul 1, 2019
Merged

Remove debugdb & colors #4651

merged 4 commits into from
Jul 1, 2019

Conversation

tac0turtle
Copy link
Member

  • Newdebugdb is removed from tendermint
  • colors is removed from tendermint

Signed-off-by: Marko Baricevic [email protected]

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: clog add [section] [stanza] [message]

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

- Newdebugdb is removed from tendermint
- colors is removed from tendermint

Signed-off-by: Marko Baricevic <[email protected]>
@codecov
Copy link

codecov bot commented Jul 1, 2019

Codecov Report

Merging #4651 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4651      +/-   ##
==========================================
+ Coverage   54.97%   54.98%   +0.01%     
==========================================
  Files         272      272              
  Lines       17027    17027              
==========================================
+ Hits         9361     9363       +2     
+ Misses       6980     6978       -2     
  Partials      686      686

.pending/improvements/sdk/remove-debugdb-color Outdated Show resolved Hide resolved
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@alexanderbez
Copy link
Contributor

Not worth the additional noise in the changelog.

@alexanderbez alexanderbez merged commit b5cd01d into master Jul 1, 2019
@alexanderbez alexanderbez deleted the marko/remove_debug-colors branch July 1, 2019 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants