Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Modular AnteHandler #4583

Closed
wants to merge 12 commits into from
Closed

WIP: Modular AnteHandler #4583

wants to merge 12 commits into from

Conversation

AdityaSripal
Copy link
Member

Addresses Issue #4572. Uses modular manager to execute module-antehandler functions in fixed sequence.

Will allow modules to define their own ante-logic and then applications can compose these functions easily to create the application's antehandler

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: clog add [section] [stanza] [message]

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@AdityaSripal AdityaSripal changed the title Aditya/modular ante WIP: Modular AnteHandler Jun 18, 2019
@fedekunze
Copy link
Collaborator

@AdityaSripal does #4844 address this problem?

@alexanderbez
Copy link
Contributor

@fedekunze no, they're somewhat orthogonal issues.

@AdityaSripal AdityaSripal mentioned this pull request Aug 22, 2019
5 tasks
}

// remove fee coins and return
acc.SetCoins(newCoins)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error return value of acc.SetCoins is not checked (from errcheck)

@AdityaSripal
Copy link
Member Author

Closing in favor of SimpleDecorators in #4942

@AdityaSripal AdityaSripal deleted the aditya/modular-ante branch August 28, 2019 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants