R4R: Using QueryWithData to query unbonding delegations.

[yangyanqing]

• Targeted PR against correct branch (see CONTRIBUTING.md)

close: #4455

• Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
• Wrote tests
• Updated relevant documentation (docs/)
• Added a relevant changelog entry: clog add [section] [stanza] [message]
• rereviewed Files changed in the github PR explorer

---

For Admin Use:

• Added appropriate labels to PR (ex. wip, ready-for-review, docs)
• Reviewers Assigned
• Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

[codecov]

Codecov Report

Merging #4456 into master will increase coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #4456      +/-   ##
==========================================
+ Coverage   54.63%   54.63%   +<.01%     
==========================================
  Files         250      250              
  Lines       16061    16064       +3     
==========================================
+ Hits         8775     8777       +2     
- Misses       6641     6642       +1     
  Partials      645      645

[codecov]

Codecov Report

Merging #4456 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #4456      +/-   ##
==========================================
- Coverage    54.6%   54.57%   -0.03%     
==========================================
  Files         250      250              
  Lines       16074    16082       +8     
==========================================
  Hits         8777     8777              
- Misses       6649     6658       +9     
+ Partials      648      647       -1

[alexanderbez]

Is there something nicer we can print? Maybe just a string or something saying no unbonding delegation exists?

[yangyanqing]

Is there something nicer we can print? Maybe just a string or something saying no unbonding delegation exists?

First, I need to find a class implement interface fmt.Stringer to hold the sentence. Any suggestion？
Second, if I find the right class, I'll add it to GetCmdQueryValidatorDelegations().

[yangyanqing]

x/staking/querier/querier.go had implement return Error when no delegation was found. But the cli did not call queryUnbondingDelegation and queryDelegatorUnbondingDelegations.

So I replace QueryStore() by QueryWithData().

But I can't find the way to verify the modification, there was no cli_test on master.

@alexanderbez

[alexanderbez]

utACK ☕️