Implement private keys export/import symmetric functionalities #4436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alessio
changed the title
Codecov Report
@@ Coverage Diff @@
## master #4436 +/- ##
==========================================
+ Coverage 54.58% 54.63% +0.05%
==========================================
Files 248 250 +2
Lines 15967 16038 +71
==========================================
+ Hits 8716 8763 +47
- Misses 6617 6629 +12
- Partials 634 646 +12 |
Allow users to encrypt ASCII-armor output with different passphrase.
alessio
changed the title
jleni
reviewed
May 30, 2019
| if err != nil { | ||
| return err | ||
| } | ||
| encryptPassword, err := input.GetPassword("Enter passphrase to encrypt the exported key:", buf) |
There was a problem hiding this comment.
As we discussed earlier, maybe we should open another issue for this, however, I think it would be good to improve input.GetPassword to ensure that something like 12345678 is not accepted.
jleni
reviewed
May 30, 2019
jleni
reviewed
May 30, 2019
Co-Authored-By: Alexander Bezobchuk <[email protected]>
Co-Authored-By: Alexander Bezobchuk <[email protected]>
jleni
approved these changes
May 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Keybase's ExportPrivKey()/ImportPrivKey() API calls to export/import
ASCII-armored private keys. Relevant keys subcommands are provided as well.
Closes: #2020
docs/)clog add [section] [stanza] [message]Files changedin the github PR explorerFor Admin Use: