Add Proper query to BaseApp and rootMultiStore #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #404 +/- ##
==========================================
+ Coverage 51.42% 52.13% +0.7%
==========================================
Files 34 34
Lines 1548 1619 +71
==========================================
+ Hits 796 844 +48
- Misses 702 721 +19
- Partials 50 54 +4 |
Closed
adrianbrink
reviewed
Feb 2, 2018
|
|
||
| "golang.org/x/crypto/ripemd160" | ||
|
|
There was a problem hiding this comment.
No line between external imports.
There was a problem hiding this comment.
https://github.com/tendermint/coding/blob/master/go/coding_standard.md#importing-libraries
In some cases, it's nice to separate into three: standard lib, external libs, tendermint libs.
ethanfrey
force-pushed
the
feature/multi-query
branch
from
a65826c to
7e7f480
Compare
ebuchman
previously approved these changes
Feb 6, 2018
ebuchman
force-pushed
the
feature/multi-query
branch
from
99a2ba1 to
d48c819
Compare
ParthDesai
pushed a commit
to ChorusOne/cosmos-sdk
that referenced
this pull request
Apr 19, 2021
gibson042
pushed a commit
to gibson042/cosmos-sdk
that referenced
this pull request
Apr 12, 2024
chore: silence some lint warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a Queryable interface, implemented by both rootMultiStore and iavlStore.
Path is assumed to be "/storename/subpath"
Multistore will look up the store by name, and if it is registered, and implements Queryable,
then it delegates the query to the substore.
iavlStore implements Query as the old sdk did in the application level. Tested it works directly on the iavlStore as expected.