WIP: Alessio/safe coins #3678
Closed
WIP: Alessio/safe coins #3678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rigelrozanski
changed the base branch from
develop
to
rigel/consistent-operators
alessio
force-pushed
the
alessio/safe-coins
branch
from
6e34853
to
c985ece
Compare
jackzampolin
changed the base branch from
rigel/consistent-operators
to
develop
alessio
force-pushed
the
alessio/safe-coins
branch
from
786323e
to
0bf788d
Compare
jaekwon
reviewed
Feb 27, 2019
| // IsAllLT returns True iff for every denom in coins, the denom is present at | ||
| // a smaller amount in coinsB. | ||
| // IsAllLT returns true if all denoms in coins | ||
| // are less than their counterparts in coinsB. | ||
| func (coins Coins) IsAllLT(coinsB Coins) bool { |
There was a problem hiding this comment.
I agree, IsAllLT can actually be removed - it's unused.
alessio
force-pushed
the
alessio/safe-coins
branch
from
70111cc
to
eca60dd
Compare
added 2 commits
March 1, 2019 10:09
This was referenced Mar 7, 2019
|
Bump @alessio - has this since been supplanted, or not? |
|
Not quite yet, not entirely. Chunks have been ported though already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added entries in
PENDING.mdwith issue #rereviewed
Files changedin the github PR explorerFor Admin Use: