Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: Add JSON Struct Tags to Vesting Accounts #3651

Merged
merged 1 commit into from
Feb 14, 2019

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Feb 14, 2019

closes: #3648


  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Feb 14, 2019

Codecov Report

Merging #3651 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #3651   +/-   ##
========================================
  Coverage    60.92%   60.92%           
========================================
  Files          188      188           
  Lines        14084    14084           
========================================
  Hits          8581     8581           
  Misses        4959     4959           
  Partials       544      544

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@jackzampolin jackzampolin merged commit f72a7c3 into develop Feb 14, 2019
@jackzampolin jackzampolin deleted the bez/3648-vesting-json-tags branch February 14, 2019 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add struct tags so that vesting accounts marshal properly
3 participants