-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
R4R: Indicate build flags in version #3620
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
rebased, it should build correctly now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could also use a description of which build tags are available and what functionality is enabled by each. Maybe as a note in /docs/gaia/installation.md
?
At the moment, the |
4f25bce
to
84a3540
Compare
@jleni dixit:
That's doable, I can deal with it. |
This PR adds build tags to the version command:
cosmos-sdk: 0.31.1-10-gfe548c08
git commit: fe548c0
vendor hash: 1aec7edfad9888a967b3e9063e42f66b28f447e6
build tags: netgo ledger
go version go1.11.5 linux/amd64
This is useful to understand which features were enabled when building the binary.
The issue is related to #3528
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Updated relevant documentation (
docs/
)Added entries in
PENDING.md
with issue #rereviewed
Files changed
in the github PR explorerWrote tests
For Admin Use: