Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: Print commit ID in hex #2917

Merged
merged 1 commit into from
Nov 27, 2018
Merged

R4R: Print commit ID in hex #2917

merged 1 commit into from
Nov 27, 2018

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Nov 27, 2018

closes: #2912


  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@cwgoes cwgoes merged commit cdb027e into develop Nov 27, 2018
@cwgoes cwgoes deleted the bez/commit-sync-log-hex branch November 27, 2018 17:24
@codecov
Copy link

codecov bot commented Nov 27, 2018

Codecov Report

Merging #2917 into develop will decrease coverage by 0.07%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #2917      +/-   ##
===========================================
- Coverage     56.4%   56.33%   -0.08%     
===========================================
  Files          120      120              
  Lines         8416     8416              
===========================================
- Hits          4747     4741       -6     
- Misses        3347     3353       +6     
  Partials       322      322

chillyvee pushed a commit to chillyvee/cosmos-sdk that referenced this pull request Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix debug logs for Commit synced
2 participants