R4R: fix tx search

[fedekunze]

Closes #2819

• Fixes bug that prevented multiple query parameters on /txs and on CLI gaiacli query txs
• removed ' ' wrapping the tag value

---

• Targeted PR against correct branch (see CONTRIBUTING.md)

• Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

• Wrote tests

• Updated relevant documentation (docs/)

• Added entries in PENDING.md with issue #

• rereviewed Files changed in the github PR explorer

---

For Admin Use:

• Added appropriate labels to PR (ex. wip, ready-for-review, docs)
• Reviewers Assigned
• Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (develop@71aec46). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop    #2842   +/-   ##
==========================================
  Coverage           ?   56.34%           
==========================================
  Files              ?      120           
  Lines              ?     8418           
  Branches           ?        0           
==========================================
  Hits               ?     4743           
  Misses             ?     3353           
  Partials           ?      322

[alexanderbez]

Looking through this makes sense, but I'd like to test this first. Will do so in a bit ⚡️

[jackzampolin]

Looks good to me! And docs updated. It would be really nice to have a document that describes what tags are applied by each module and how to properly use this functionality, but maybe a followup PR?

Pulled this down, ran tests, as well as manually testing the functionality so the code gets a 👍 from me, but can we also fix this functionality in the CLI? There is a gaiacli query txs that needs to get looked at too.

[fedekunze]

It would be really nice to have a document that describes what tags are applied by each module and how to properly use this functionality, but maybe a followup PR?

@jackzampolin I think you're referring to #1780 ?

can we also fix this functionality in the CLI?

Was that failing as well ?

[alexanderbez]

Nice @fedekunze! I left some minor feedback ⚡️

[cwgoes]

Agree with @alexanderbez & two minor comments - otherwise LGTM.

addressed

[fedekunze]

this is R4R again @alexanderbez @jackzampolin @cwgoes @gamarin2

[fedekunze]

Addressed comments

[jackzampolin]

Love the docs update! This is working for me when I tested and all the changes have been incorporated!

addressed comments and updated docs

[cwgoes]

Tested ACK