Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update contributing.md with new merge policy #2789
Update contributing.md with new merge policy #2789
Changes from 2 commits
51a91cd
7d13028
72142a6
4e52ad6
3804e0a
303f264
3b29591
c76fb6c
11ce509
bbf8cca
20b2e07
dca52ff
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
K so I guess the only funny issue, is when you perform a "request changes" the only way to override that is via an approve right? If that's the case then maybe you want to "approve" something in the github sense to indicate that you're satisfied with the changes made, however this doesn't mean you've reviewed it deeply.... For that reason I think we may still need
DeepAck
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the answer here is only
Approve
if you have fully reviewed the changes. If youRequest Changes
that would mean you need to fully review toApprove
which seems like a good policy (if you know enough to request changes on the PR, then you should also be able to review it fully). Thoughts?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup that sounds fine, so I guess if you are making only "surface level" reviews, you can submit your review as a "comment" instead of a "request changes"
want to incorporate that idea into this section?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can also dismiss your review after you request changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a few more points for reviewers:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this section meant to be duplicate of the update docs/DOCS_README ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. We might just want to point that file to this spot in the
CONTRIBUTING.md
doc