Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R4R]: Cleanup bank keeper #2719

Merged
merged 2 commits into from
Nov 12, 2018
Merged

[R4R]: Cleanup bank keeper #2719

merged 2 commits into from
Nov 12, 2018

Conversation

alexanderbez
Copy link
Contributor

The bank keeper was broken up into sub-interfaces (view, send, main). However, we were repeating a bulk of the methods in each. This simply removes duplicate code and DRYs it up.

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alexanderbez alexanderbez added wip Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. labels Nov 7, 2018
@alexanderbez alexanderbez changed the title [WIP]: Cleanup bank keeper [R4R]: Cleanup bank keeper Nov 7, 2018
@codecov
Copy link

codecov bot commented Nov 7, 2018 •
edited
Loading

Codecov Report

Merging #2719 into release/v0.26.0 will decrease coverage by 0.01%.
The diff coverage is 100%.

@@                 Coverage Diff                 @@
##           release/v0.26.0    #2719      +/-   ##
===================================================
- Coverage            57.63%   57.62%   -0.02%     
===================================================
  Files                  154      154              
  Lines                 9570     9563       -7     
===================================================
- Hits                  5516     5511       -5     
+ Misses                3690     3688       -2     
  Partials               364      364

@alexanderbez
Copy link
Contributor Author

alexanderbez commented Nov 7, 2018 •
edited
Loading

@cwgoes mind getting this in (I'd like another approval)?

@sunnya97
Copy link
Member

sunnya97 commented Nov 7, 2018

@alexanderbez Here is the context for why the Keepers are like this. #831 (comment)

rigelrozanski
rigelrozanski reviewed Nov 7, 2018
View reviewed changes
x/bank/keeper.go Outdated Show resolved Hide resolved
x/bank/keeper.go Outdated Show resolved Hide resolved
x/bank/keeper.go Show resolved Hide resolved
x/bank/keeper.go Outdated Show resolved Hide resolved
@alexanderbez
Copy link
Contributor Author

@rigelrozanski addressed your comments 👍

@alexanderbez alexanderbez changed the base branch from release/v0.26.0 to develop November 7, 2018 21:43
@cwgoes
Copy link
Contributor

cwgoes commented Nov 8, 2018

@sunnya97 I don't think we have diamond inheritance in this case, so this pattern seems OK.

@alexanderbez
Copy link
Contributor Author

Yea there is no diamond inheritance here afaict.

cwgoes
cwgoes approved these changes Nov 12, 2018
View reviewed changes
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@cwgoes cwgoes merged commit bbf8e54 into develop Nov 12, 2018
@cwgoes cwgoes deleted the bez/bank-keeper-cleanup branch November 12, 2018 19:06
@snyk-bot snyk-bot mentioned this pull request Jul 6, 2021
Closed
chillyvee pushed a commit to chillyvee/cosmos-sdk that referenced this pull request Mar 1, 2024
@dependabot
chore(deps): Bump actions/cache from 3.3.1 to 3.3.2 (cosmos#2719)
81e0eda 
Bumps [actions/cache](https://github.com/actions/cache) from 3.3.1 to 3.3.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/cache/releases">actions/cache's releases</a>.</em></p>
<blockquote>
<h2>v3.3.2</h2>
<h2>What's Changed</h2>
<ul>
<li>Fixed readme with new segment timeout values by <a href="https://github.com/kotewar"><code>@​kotewar</code></a> in <a href="https://redirect.github.com/actions/cache/pull/1133">actions/cache#1133</a></li>
<li>Readme fixes by <a href="https://github.com/kotewar"><code>@​kotewar</code></a> in <a href="https://redirect.github.com/actions/cache/pull/1134">actions/cache#1134</a></li>
<li>Updated description of the lookup-only input for main action by <a href="https://github.com/kotewar"><code>@​kotewar</code></a> in <a href="https://redirect.github.com/actions/cache/pull/1130">actions/cache#1130</a></li>
<li>Change two new actions mention as quoted text by <a href="https://github.com/bishal-pdMSFT"><code>@​bishal-pdMSFT</code></a> in <a href="https://redirect.github.com/actions/cache/pull/1131">actions/cache#1131</a></li>
<li>Update Cross-OS Caching tips by <a href="https://github.com/pdotl"><code>@​pdotl</code></a> in <a href="https://redirect.github.com/actions/cache/pull/1122">actions/cache#1122</a></li>
<li>Bazel example (Take <a href="https://redirect.github.com/actions/cache/issues/2">#2</a>️⃣) by <a href="https://github.com/vorburger"><code>@​vorburger</code></a> in <a href="https://redirect.github.com/actions/cache/pull/1132">actions/cache#1132</a></li>
<li>Remove actions to add new PRs and issues to a project board by <a href="https://github.com/jorendorff"><code>@​jorendorff</code></a> in <a href="https://redirect.github.com/actions/cache/pull/1187">actions/cache#1187</a></li>
<li>Consume latest toolkit and fix dangling promise bug by <a href="https://github.com/chkimes"><code>@​chkimes</code></a> in <a href="https://redirect.github.com/actions/cache/pull/1217">actions/cache#1217</a></li>
<li>Bump action version to 3.3.2 by <a href="https://github.com/bethanyj28"><code>@​bethanyj28</code></a> in <a href="https://redirect.github.com/actions/cache/pull/1236">actions/cache#1236</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/vorburger"><code>@​vorburger</code></a> made their first contribution in <a href="https://redirect.github.com/actions/cache/pull/1132">actions/cache#1132</a></li>
<li><a href="https://github.com/jorendorff"><code>@​jorendorff</code></a> made their first contribution in <a href="https://redirect.github.com/actions/cache/pull/1187">actions/cache#1187</a></li>
<li><a href="https://github.com/chkimes"><code>@​chkimes</code></a> made their first contribution in <a href="https://redirect.github.com/actions/cache/pull/1217">actions/cache#1217</a></li>
<li><a href="https://github.com/bethanyj28"><code>@​bethanyj28</code></a> made their first contribution in <a href="https://redirect.github.com/actions/cache/pull/1236">actions/cache#1236</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/cache/compare/v3...v3.3.2">https://github.com/actions/cache/compare/v3...v3.3.2</a></p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/actions/cache/blob/main/RELEASES.md">actions/cache's changelog</a>.</em></p>
<blockquote>
<h3>3.3.1</h3>
<ul>
<li>Reduced segment size to 128MB and segment timeout to 10 minutes to fail fast in case the cache download is stuck.</li>
</ul>
<h3>3.3.2</h3>
<ul>
<li>Fixes bug with Azure SDK causing blob downloads to get stuck.</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/actions/cache/commit/704facf57e6136b1bc63b828d79edcd491f0ee84"><code>704facf</code></a> Merge pull request <a href="https://redirect.github.com/actions/cache/issues/1236">#1236</a> from actions/bethanyj28/bump-version</li>
<li><a href="https://github.com/actions/cache/commit/17e2888746ae4cdbac78cbb1a45a157d310c0e53"><code>17e2888</code></a> Add to RELEASES.md</li>
<li><a href="https://github.com/actions/cache/commit/667d8fdfa213683cee9fcaad43be0f25322bef02"><code>667d8fd</code></a> bump action version to 3.3.2</li>
<li><a href="https://github.com/actions/cache/commit/f7ebb81a3f195b4fb88dab7c14e2f7aff52045aa"><code>f7ebb81</code></a> Consume latest toolkit and fix dangling promise bug (<a href="https://redirect.github.com/actions/cache/issues/1217">#1217</a>)</li>
<li><a href="https://github.com/actions/cache/commit/67b839edb68371cc5014f6cea11c9aa77238de78"><code>67b839e</code></a> Merge pull request <a href="https://redirect.github.com/actions/cache/issues/1187">#1187</a> from jorendorff/jorendorff/rm-add-to-project</li>
<li><a href="https://github.com/actions/cache/commit/57f0e3f198251983d70fc3c83e71b973822da983"><code>57f0e3f</code></a> Remove actions to add new PRs and issues to a project board</li>
<li><a href="https://github.com/actions/cache/commit/04f198bf0b2a39f7230a4304bf07747a0bddf146"><code>04f198b</code></a> Merge pull request <a href="https://redirect.github.com/actions/cache/issues/1132">#1132</a> from vorburger/bazel-example</li>
<li><a href="https://github.com/actions/cache/commit/bd9b49b6c3b91fb2f92c80901a466ba260a746eb"><code>bd9b49b</code></a> Merge branch 'main' into bazel-example</li>
<li><a href="https://github.com/actions/cache/commit/ea0503788c59256f4da17725d04df850ca027df5"><code>ea05037</code></a> Merge pull request <a href="https://redirect.github.com/actions/cache/issues/1122">#1122</a> from actions/pdotl-patch-1</li>
<li><a href="https://github.com/actions/cache/commit/6a1a45d49b4738670d9804cd9a8fee56a01b6bf2"><code>6a1a45d</code></a> Merge branch 'main' into pdotl-patch-1</li>
<li>Additional commits viewable in <a href="https://github.com/actions/cache/compare/v3.3.1...v3.3.2">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/cache&package-manager=github_actions&previous-version=3.3.1&new-version=3.3.2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alessio alessio alessio approved these changes

@rigelrozanski rigelrozanski rigelrozanski approved these changes

@cwgoes cwgoes cwgoes approved these changes

@sunnya97 sunnya97 Awaiting requested review from sunnya97

@ValarDragon ValarDragon Awaiting requested review from ValarDragon

Assignees
No one assigned
Labels
Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alexanderbez @sunnya97 @cwgoes @alessio @rigelrozanski