WIP: Refresh Gopkg.* files #2689
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to goleveldb's most recent revision Should close #2649
alessio
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
cwgoes
reviewed
Nov 5, 2018
| // return getKeyBaseFromDirWithOpts(rootDir, &opt.Options{ReadOnly: true}) | ||
| return getKeyBaseFromDirWithOpts(rootDir, nil) | ||
| return getKeyBaseFromDirWithOpts(rootDir, &opt.Options{ReadOnly: true}) | ||
| //return getKeyBaseFromDirWithOpts(rootDir, nil) |
There was a problem hiding this comment.
Can we just delete this line now?
There was a problem hiding this comment.
Nope, it does not work yet
|
Bump @alessio, are we still waiting on upstream? |
|
I think we can go ahead and close this as we have updated deps for the release? |
|
Upstream didn't fix the issue for us. I'll investigate further. Closing this for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to goleveldb's most recent revision
Should close #2649
docs/)PENDING.mdwith issue #Files changedin the github PR explorerFor Admin Use: