Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R4R: Change --gas=0 semantic and introduce --gas=simulate #2306

Merged
merged 6 commits into from
Sep 12, 2018
Merged

R4R: Change --gas=0 semantic and introduce --gas=simulate #2306

merged 6 commits into from
Sep 12, 2018

Commits on Sep 11, 2018

  1. Change --gas=0 semantic and introduce --gas=simulate 

    Make --gas flag accept a conventional "simulate" string value in addition
to integers. Passing --gas=simulate would trigger the tx simulation and
set the gas according to the gas estimate returned by the simulation.
Any other integer value passed to --gas would be interpreted as-is and
and set as gas wanted value.

Closes: #2300
    Alessio Treglia committed Sep 11, 2018
    Configuration menu
    Copy the full SHA
    ceba51a View commit details
    Browse the repository at this point in the history

  2. Add test cases with gas=0

    Alessio Treglia committed Sep 11, 2018
    Configuration menu
    Copy the full SHA
    40cd51e View commit details
    Browse the repository at this point in the history

  3. ACK suggestion from @alexanderbez

    Alessio Treglia committed Sep 11, 2018
    Configuration menu
    Copy the full SHA
    4222b9d View commit details
    Browse the repository at this point in the history

  4. s/GasFlagSimulateString/GasFlagSimulate/

    Alessio Treglia committed Sep 11, 2018
    Configuration menu
    Copy the full SHA
    7f15866 View commit details
    Browse the repository at this point in the history

  5. Drop TODO comment on Gas type

    Alessio Treglia committed Sep 11, 2018
    Configuration menu
    Copy the full SHA
    461261a View commit details
    Browse the repository at this point in the history

  6. Enrich TODO with ref

    Alessio Treglia committed Sep 11, 2018
    Configuration menu
    Copy the full SHA
    cb05261 View commit details
    Browse the repository at this point in the history