Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix dead link in UPGRADING.md #23059

Merged
merged 2 commits into from
Dec 23, 2024
Merged

docs: fix dead link in UPGRADING.md #23059

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7cb8574
docs: fix dead link in `UPGRADING.md`
BabyHalimao Dec 21, 2024
855f3e4
Merge branch 'main' into docs/changelog
hieuvubk Dec 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion UPGRADING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ It is additional to the changes described here.

In this section we describe the changes made in Cosmos SDK' SimApp.
**These changes are directly applicable to your application wiring.**
Please read this section first, but for an exhaustive list of changes, refer to the [CHANGELOG](https://github.com/cosmos/cosmos-sdk/blob/main/simapp/CHANGELOG.md).
Please read this section first, but for an exhaustive list of changes, refer to the [CHANGELOG](https://github.com/cosmos/cosmos-sdk/blob/release/v0.52.x/simapp/CHANGELOG.md).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix dead link to SimApp CHANGELOG

The link to simapp/CHANGELOG.md is broken as the file was removed in PR #23009. Since this section discusses important changes in SimApp that are directly applicable to application wiring, consider either:

  1. Restoring the CHANGELOG file with the relevant information, or
  2. Including the important changes directly in this section of the upgrade guide.


#### Client (`root.go`)

Expand Down
Loading