Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove snapshot commands #23015

Merged
merged 1 commit into from
Dec 19, 2024
Merged

chore: remove snapshot commands #23015

merged 1 commit into from
Dec 19, 2024

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Dec 19, 2024

Description

ref: #22904

Those commands are on server/v2/store now.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

  • Chores
    • Removed multiple commands related to snapshot management from the CLI, including functionalities for listing, deleting, loading, exporting, and restoring snapshots.

Copy link
Contributor

coderabbitai bot commented Dec 19, 2024

📝 Walkthrough

Walkthrough

The pull request involves the deletion of multiple files related to snapshot management in the Cosmos SDK client package. Specifically, six files were removed from the client/snapshot/ directory: cmd.go, delete.go, dump.go, export.go, list.go, and restore.go. These files contained command-line interface (CLI) implementations for various snapshot-related operations such as listing, deleting, exporting, loading, and restoring snapshots. The removal suggests a potential refactoring or restructuring of the snapshot management functionality in the Cosmos SDK.

Changes

File Change Summary
client/snapshot/cmd.go Removed generic command definition for snapshot management
client/snapshot/delete.go Removed command for deleting local snapshots
client/snapshot/dump.go Removed functionality for creating snapshot dumps in archive format
client/snapshot/export.go Removed generic command for exporting application state snapshots
client/snapshot/list.go Removed command for listing local snapshots
client/snapshot/load.go Removed command for loading snapshot archives
client/snapshot/restore.go Removed command and helper function for restoring snapshots

Possibly related PRs

Suggested Labels

C:server/v2, C:Store

Suggested Reviewers

  • hieuvubk
  • kocubinski
  • tac0turtle
  • akhilkumarpilli

📜 Recent review details

Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4a073fa and 9e0a173.

📒 Files selected for processing (7)
  • client/snapshot/cmd.go (0 hunks)
  • client/snapshot/delete.go (0 hunks)
  • client/snapshot/dump.go (0 hunks)
  • client/snapshot/export.go (0 hunks)
  • client/snapshot/list.go (0 hunks)
  • client/snapshot/load.go (0 hunks)
  • client/snapshot/restore.go (0 hunks)
💤 Files with no reviewable changes (7)
  • client/snapshot/cmd.go
  • client/snapshot/delete.go
  • client/snapshot/list.go
  • client/snapshot/dump.go
  • client/snapshot/restore.go
  • client/snapshot/export.go
  • client/snapshot/load.go

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the C:CLI label Dec 19, 2024
@julienrbrt julienrbrt marked this pull request as ready for review December 19, 2024 19:06
@julienrbrt julienrbrt requested review from JulianToledano and a team as code owners December 19, 2024 19:06
@julienrbrt julienrbrt added this pull request to the merge queue Dec 19, 2024
Merged via the queue into main with commit 4f5c3d8 Dec 19, 2024
78 checks passed
@julienrbrt julienrbrt deleted the julien/remove-snapshot branch December 19, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants