build(deps): fix x/protocolpool version in x/feegrant #22840
Conversation
📝 WalkthroughWalkthroughThe changes in this pull request primarily involve updates to the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant GoModule
participant ProtocolPool
User->>GoModule: Update Go version to 1.23.3
User->>GoModule: Add cosmossdk.io/x/protocolpool
GoModule->>ProtocolPool: Include ProtocolPool dependency
GoModule->>GoModule: Update replacement directives
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
|
what error is this giving you that is causing issues? tests and everything runs fine in the sdk. not sure what the issue is |
|
in v0.52: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
x/feegrant/go.mod (1)
Line range hint
3-3: Invalid Go version specifiedThe Go version
1.23.3is invalid. Go versions follow semantic versioning with only two components (major.minor), and the latest stable version is 1.22.x.Please update to a valid Go version:
-go 1.23.3 +go 1.22
📜 Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
⛔ Files ignored due to path filters (1)
x/feegrant/go.sumis excluded by!**/*.sum
📒 Files selected for processing (1)
x/feegrant/go.mod(1 hunks)
🔇 Additional comments (2)
x/feegrant/go.mod (2)
Line range hint 52-52: Verify protocolpool version compatibility
The added protocolpool dependency version 0.0.0-20230925135524-a1bc045b3190 should be verified for compatibility with other module versions, especially with core and store versions.
✅ Verification successful
Let me gather more information about the protocolpool dependency versions.
Based on the analysis of the codebase, I can now provide a final response regarding the protocolpool version compatibility.
Protocolpool version is compatible with core dependencies
The protocolpool module is tightly integrated with the codebase and is being used as a local module (via replace directives) rather than an external dependency. All the go.mod files show consistent replace directives pointing to the local protocolpool module, ensuring version compatibility across the codebase.
Key observations:
- The module is referenced via replace directives in multiple modules (staking, slashing, gov, etc.)
- It's properly integrated with core modules like distribution which has been updated to delegate community pool functionality to protocolpool
- The module follows the same versioning pattern as other core modules in the codebase
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Check if the protocolpool version is compatible with other dependencies
gh api graphql -f query='
{
repository(owner: "cosmos", name: "cosmos-sdk") {
object(expression: "main") {
... on Commit {
history(path: "x/protocolpool/go.mod") {
nodes {
committedDate
oid
messageHeadline
}
}
}
}
}
}'
Length of output: 17751
Script:
#!/bin/bash
# Check protocolpool dependency in go.mod files
fd -e mod -x cat {} \; | grep -A 5 -B 5 "protocolpool"
# Check if protocolpool is used in the codebase and its imports
rg -A 3 "protocolpool" --type go
Length of output: 103727
190-190: Verify the protocolpool module path
The replace directive for protocolpool points to a relative path ../protocolpool. Please ensure this path is correct and the module exists at this location.
✅ Verification successful
Based on the search results, I can see that the protocolpool module exists within the repository at x/protocolpool/. The replace directive in the review comment points to ../protocolpool, which is correct as it references the module relative to the feegrant module's location at x/feegrant/.
The replace directive path is correct
The protocolpool module is properly located within the repository at x/protocolpool/ and the relative path ../protocolpool from x/feegrant/go.mod correctly points to it. This is consistent with the repository's module structure and the ongoing modularization effort.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Verify the existence of the protocolpool module
if [ -d "../protocolpool" ]; then
echo "protocolpool module directory exists"
if [ -f "../protocolpool/go.mod" ]; then
echo "protocolpool go.mod exists"
cat "../protocolpool/go.mod"
fi
fi
Length of output: 28
Script:
#!/bin/bash
# Let's try to find the protocolpool module within the repository
fd protocolpool
# Check if there's a go.mod file mentioning protocolpool
rg -l "protocolpool" --type go-mod
# Look for any references to protocolpool in the codebase
rg "protocolpool" -g "!*.sum" -g "!*.mod"
Length of output: 119519
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
x/feegrant/go.mod (2)
Line range hint
3-3: Invalid Go version specifiedThe Go version
1.23.3is invalid. Go versions follow semantic versioning with only two components (e.g., 1.22), and the latest stable version is 1.22.1 as of March 2024.Apply this diff to fix the Go version:
-go 1.23.3 +go 1.22
189-191: LGTM: Replacement directive aligns with module structureThe addition of the protocolpool replacement directive follows the same pattern as other module replacements. Note the TODO comment about removing these replacements after spinning out all modules.
Consider creating a tracking issue for the TODO about removing replacements after spinning out all modules.
📜 Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
⛔ Files ignored due to path filters (1)
x/feegrant/go.sumis excluded by!**/*.sum
📒 Files selected for processing (1)
x/feegrant/go.mod(1 hunks)
🔇 Additional comments (1)
x/feegrant/go.mod (1)
Line range hint 52-52: Verify the protocolpool version
The PR aims to fix the version of x/protocolpool. Please confirm if the pseudo-version v0.0.0-20230925135524-a1bc045b3190 from September 2023 is the intended version.
✅ Verification successful
The protocolpool version is correctly managed by the replace directive
The pseudo-version v0.0.0-20230925135524-a1bc045b3190 is not a concern because the module is actually replaced with a local version through the replace directive: cosmossdk.io/x/protocolpool => ../protocolpool. This is the standard approach for managing internal module dependencies within a monorepo, where modules are developed together and their versions are controlled by the main repository.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check the available versions and commit history of protocolpool
# Check if the commit exists in the repository
gh api repos/cosmos/cosmos-sdk/commits/a1bc045b3190 --jq '.sha'
# List tags containing protocolpool changes
git tag --sort=-creatordate | while read -r tag; do
if git ls-tree -r "$tag" | grep -q "x/protocolpool"; then
echo "$tag"
fi
done
Length of output: 233
Script:
#!/bin/bash
# Let's try a different approach to verify the protocolpool version
# First, check the current version in go.mod
grep "cosmossdk.io/x/protocolpool" x/feegrant/go.mod
# Then check for any references to protocolpool in the codebase
rg "protocolpool" --type go
# Also check the imports in Go files
rg "cosmossdk.io/x/protocolpool" --type go
Length of output: 73821
Script:
#!/bin/bash
# Let's check the replace directive and the actual module location
grep -A 1 "cosmossdk.io/x/protocolpool" x/feegrant/go.mod
# Check if there's a go.mod in the protocolpool directory
cat ../protocolpool/go.mod 2>/dev/null || echo "No go.mod found in protocolpool directory"
# Check if there are any version tags in the protocolpool directory
git -C ../protocolpool tag -l 2>/dev/null || echo "Not a git repository or no tags found"
Length of output: 532
julienrbrt
changed the title
Description
Similar to #22839, but targetting
mainAuthor Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...
Summary by CodeRabbit
New Features
cosmossdk.io/x/protocolpoolmodule as a new dependency.Bug Fixes
cosmossdk.iomodules.