refactor(testutil)!: remove cmdtest
#22826
Conversation
julienrbrt
added
the
backport/v0.52.x
|
Warning Rate limit exceeded@julienrbrt has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 17 minutes and 2 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (6)
📝 Walkthrough📝 Walkthrough📝 WalkthroughWalkthroughThe pull request includes updates to the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
julienrbrt
changed the title
cmdtestcmdtest
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (3)
CHANGELOG.md (3)
Line range hint
1-1: Add title to changelog fileThe changelog file should start with a clear title like "# Changelog" to follow standard documentation practices.
+ # Changelog
Line range hint
12-15: Improve version header formatting consistencyThe version headers should follow a consistent format with release date. Some headers are missing the release date format.
- ## [v0.47.0](https://github.com/cosmos/cosmos-sdk/releases/tag/v0.47.0) - 2023-03-14 + ## [v0.47.0](https://github.com/cosmos/cosmos-sdk/releases/tag/v0.47.0) - 2023-03-14
Line range hint
2349-2349: Add missing previous versions linkThe "Previous Releases" section should include a link to view the full history of changes before v0.40.0.
- [CHANGELOG of previous versions](https://github.com/cosmos/cosmos-sdk/blob/c17c3caab86a1426a1eef4541e8203f5f54a1a54/CHANGELOG.md#v0391---2020-08-11) (pre Stargate). + [CHANGELOG of previous versions](https://github.com/cosmos/cosmos-sdk/blob/c17c3caab86a1426a1eef4541e8203f5f54a1a54/CHANGELOG.md) (pre Stargate)
📜 Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
📒 Files selected for processing (6)
CHANGELOG.md(1 hunks)client/keys/show.go(1 hunks)tests/integration/genutil/export_test.go(0 hunks)testutil/cmdtest/system.go(0 hunks)version/command.go(2 hunks)version/version_test.go(0 hunks)
💤 Files with no reviewable changes (3)
- version/version_test.go
- tests/integration/genutil/export_test.go
- testutil/cmdtest/system.go
🧰 Additional context used
📓 Path-based instructions (3)
version/command.go (1)
Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
client/keys/show.go (1)
Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
CHANGELOG.md (1)
Pattern **/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
🔇 Additional comments (2)
version/command.go (1)
31-31: LGTM! Consistent simplification of output handling
The changes simplify output handling by using cmd.Println() instead of fmt.Fprintln(cmd.OutOrStdout(), ...). This is a good improvement as it:
- Reduces code verbosity
- Maintains the same functionality
- Uses Cobra's built-in output handling consistently
Also applies to: 56-56
client/keys/show.go (1)
146-146: LGTM! Consistent with codebase-wide output handling improvements
The change to use cmd.Println(out) aligns with similar improvements in other commands (e.g., version command) and:
- Maintains compatibility with QR code generation
- Preserves the existing functionality
- Simplifies the output handling code
Co-authored-by: Julien Robert <[email protected]>
Description
Reduces amount of testing framework. Similar to #22392.
This isn't used by anyone and the alternative is a two liner or using systemtests / intergration tests framework.
(reverts #15251)
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...
Summary by CodeRabbit
New Features
Improvements
Bug Fixes
Documentation