fix(client/v2/autocli): add CoinDec flag

client/v2/CHANGELOG.md

@@ -60,6 +60,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
 
 * [#21853](https://github.com/cosmos/cosmos-sdk/pull/21853) Fix `*big.Int` unmarshalling in txs.
 * [#22576](https://github.com/cosmos/cosmos-sdk/pull/22576) Fix duplicate command addition in `autocli` when custom enhanced command has a different name than module name
+* [#22817](https://github.com/cosmos/cosmos-sdk/pull/22817) Add DecCoin support in autocli flag builder.
 
 ## [v2.0.0-beta.5] - 2024-09-18
 

client/v2/autocli/flag/builder.go

@@ -60,6 +60,7 @@ func (b *Builder) init() {
 		b.messageFlagTypes["google.protobuf.Timestamp"] = timestampType{}
 		b.messageFlagTypes["google.protobuf.Duration"] = durationType{}
 		b.messageFlagTypes["cosmos.base.v1beta1.Coin"] = coinType{}
+		b.messageFlagTypes["cosmos.base.v1beta1.DecCoin"] = decCoinType{}
 	}
 
 	if b.scalarFlagTypes == nil {

client/v2/autocli/flag/dec_coin.go

@@ -0,0 +1,54 @@
+package flag
+
+import (
+	"context"
+	"errors"
+	"strings"
+
+	"google.golang.org/protobuf/reflect/protoreflect"
+
+	basev1beta1 "cosmossdk.io/api/cosmos/base/v1beta1"
+	"cosmossdk.io/client/v2/internal/coins"
+)
+
+type decCoinType struct{}
+
+type decCoinValue struct {
+	value *basev1beta1.DecCoin
+}
+
+func (c decCoinType) NewValue(*context.Context, *Builder) Value {
+	return &decCoinValue{}
+}
+
+func (c decCoinType) DefaultValue() string {
+	return "zero"
+}
+
+func (c *decCoinValue) Get(protoreflect.Value) (protoreflect.Value, error) {
+	if c.value == nil {
+		return protoreflect.Value{}, nil
+	}
+	return protoreflect.ValueOfMessage(c.value.ProtoReflect()), nil
+}
+
+func (c *decCoinValue) String() string {
+	return c.value.String()
+}
+
+func (c *decCoinValue) Set(stringValue string) error {
+	if strings.Contains(stringValue, ",") {
+		return errors.New("coin flag must be a single coin, specific multiple coins with multiple flags or spaces")
+	}
+
+	coin, err := coins.ParseDecCoin(stringValue)
+	if err != nil {
+		return err
+	}
+	c.value = coin
+	return nil
+}
+
+func (c *decCoinValue) Type() string {
+	return "cosmos.base.v1beta1.DecCoin"
+}

client/v2/internal/coins/format.go

@@ -16,20 +16,47 @@ var coinRegex = regexp.MustCompile(`^(\d+(\.\d+)?)([a-zA-Z][a-zA-Z0-9\/\:\._\-]{
 // ParseCoin parses a coin from a string. The string must be in the format
 // <amount><denom>, where <amount> is a number and <denom> is a valid denom.
 func ParseCoin(input string) (*basev1beta1.Coin, error) {
+	amount, denom, err := parseCoin(input)
+	if err != nil {
+		return nil, err
+	}
+
+	return &basev1beta1.Coin{
+		Amount: amount,
+		Denom:  denom,
+	}, nil
+}
+
+// ParseDecCoin parses a decCoin from a string. The string must be in the format
+// <amount><denom>, where <amount> is a number and <denom> is a valid denom.
+func ParseDecCoin(input string) (*basev1beta1.DecCoin, error) {
+	amount, denom, err := parseCoin(input)
+	if err != nil {
+		return nil, err
+	}
+
+	return &basev1beta1.DecCoin{
+		Amount: amount,
+		Denom:  denom,
+	}, nil
+}
+
+// parseCoin parses a coin string into its amount and denom components.
+// The input string must be in the format <amount><denom>.
+// It returns the amount string, denom string, and any error encountered.
+// Returns an error if the input is empty or doesn't match the expected format.
+func parseCoin(input string) (amount, denom string, err error) {
 	input = strings.TrimSpace(input)
 
 	if input == "" {
-		return nil, errors.New("empty input when parsing coin")
+		return "", "", errors.New("empty input when parsing coin")
 	}
 
 	matches := coinRegex.FindStringSubmatch(input)
 
 	if len(matches) == 0 {
-		return nil, errors.New("invalid input format")
+		return "", "", errors.New("invalid input format")
 	}
 
-	return &basev1beta1.Coin{
-		Amount: matches[1],
-		Denom:  matches[3],
-	}, nil
+	return matches[1], matches[3], nil
 }

client/v2/internal/coins/format_test.go

@@ -1,16 +1,72 @@
-package coins_test
+package coins
 
 import (
 	"testing"
 
 	"github.com/stretchr/testify/require"
-
-	"cosmossdk.io/client/v2/internal/coins"
 )
 
-func TestDecodeCoin(t *testing.T) {
+func Test_parseCoin(t *testing.T) {
+	tests := []struct {
+		name   string
+		input  string
+		amount string
+		denom  string
+		err    string
+	}{
+		{
+			name:   "ok",
+			input:  "1000stake",
+			amount: "1000",
+			denom:  "stake",
+		},
+		{
+			name:  "empty",
+			input: "",
+			err:   "empty input when parsing coin",
+		},
+		{
+			name:  "empty denom",
+			input: "1000",
+			err:   "invalid input format",
+		},
+		{
+			name:  "empty amount",
+			input: "stake",
+			err:   "invalid input format",
+		},
+		{
+			name:  "<denom><amount> format",
+			input: "stake1000",
+			err:   "invalid input format",
+		},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			amount, denom, err := parseCoin(tt.input)
+			if tt.err != "" {
+				require.Error(t, err)
+				require.Contains(t, err.Error(), tt.err)
+			} else {
+				require.NoError(t, err)
+				require.Equal(t, tt.amount, amount)
+				require.Equal(t, tt.denom, denom)
+			}
+		})
+	}
+}
+
+func TestParseCoin(t *testing.T) {
+	encodedCoin := "1000000000foo"
+	coin, err := ParseCoin(encodedCoin)
+	require.NoError(t, err)
+	require.Equal(t, "1000000000", coin.Amount)
+	require.Equal(t, "foo", coin.Denom)
+}
+
+func TestParseDecCoin(t *testing.T) {
 	encodedCoin := "1000000000foo"
-	coin, err := coins.ParseCoin(encodedCoin)
+	coin, err := ParseDecCoin(encodedCoin)
 	require.NoError(t, err)
 	require.Equal(t, "1000000000", coin.Amount)
 	require.Equal(t, "foo", coin.Denom)