ci: run runtime/v2 tests in CI #22769
Conversation
📝 WalkthroughWalkthroughThe pull request introduces a new job called Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
.github/workflows/v2-test.yml (1)
36-39: Add coverage reporting to match step nameThe step is named "test & coverage report creation" but doesn't generate coverage reports. Consider adding the
-coverprofileflag to match other test jobs and the step name.- cd runtime/v2 && go test -mod=readonly -race -timeout 30m -tags='ledger test_ledger_mock' + cd runtime/v2 && go test -mod=readonly -race -timeout 30m -tags='ledger test_ledger_mock' -coverprofile=coverage.txt -covermode=atomic
📜 Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
📒 Files selected for processing (1)
.github/workflows/v2-test.yml(1 hunks)
🔇 Additional comments (4)
.github/workflows/v2-test.yml (4)
17-21: LGTM: Job configuration follows best practices
The job configuration is consistent with other test jobs and correctly uses fail-fast: false to ensure all tests run even if one fails.
29-35: LGTM: Change detection patterns are well-defined
The patterns correctly capture all relevant files in the runtime/v2 module, including Go source files and dependency manifests.
22-28: Verify Go version specification
The workflow specifies Go version "1.23" which is not yet released (current stable is 1.22). While this matches other jobs, it might cause issues.
✅ Verification successful
Let me check the Go version in the repository's go.mod file to verify if this is intentional or a potential issue.
Go version 1.23 specification is correct
The Go version 1.23 specified in the workflow file matches the version declared in go.mod (1.23.2). This is consistent across all workflow files and aligns with the project's requirements.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Check if other workflows use the same Go version
rg -l "go-version: \"1\.23\"" .github/workflows/
Length of output: 633
Script:
#!/bin/bash
# Check Go version in go.mod
cat go.mod | grep -E "^go [0-9]+\.[0-9]+"
Length of output: 53
17-40: Verify required status check configuration
As mentioned in the PR objectives, this job should be marked as required. Please ensure the branch protection rules are updated to include this new job as a required status check.
Description
I was confused why #22760 never got catched before.
That's the reason. I'll mark the job as required afterwards.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...
Summary by CodeRabbit
New Features
runtime-v2, to enhance the testing capabilities of the workflow.Improvements
runtime/v2directory, ensuring more robust validation of changes.