test(system): Correct legacy chain initializer

[alpe]

Description

Fixes the testnet setup for chain upgrade system test

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title, you can find examples of the prefixes below:
• confirmed ! in the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• reviewed "Files changed" and left comments if necessary
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• updated the relevant documentation or specification, including comments for documenting Go code
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

• confirmed the correct type prefix in the PR title
• confirmed all author checklist items have been addressed
• reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)

• main

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

@alpe your pull request is missing a changelog!

[julienrbrt]

Merging this as this fixes the chain upgrade issue.
The other test does need to be fixed eventually

[hieuvubk]

I try to run in my local but still get the error in . Any idea? 👀

systemtests git:(alex/v0.52.x/22196_fix) go test -mod=readonly -tags='system_test' -v ./...  --run TestChainUpgrade --verbose
Work dir:  /Users/ggwp/Documents/Decentrio/cosmos-sdk/tests/systemtests
Setup chain: ./testnet
+++ /Users/ggwp/Documents/Decentrio/cosmos-sdk/tests/systemtests/binaries/simd testnet init-files --chain-id=testing --output-dir=./testnet --validator-count=4 --keyring-backend=test --commit-timeout=900ms --single-host --minimum-gas-prices=0.000001stake
=== RUN   TestChainUpgrade
Stop chain
    upgrade_test.go:27: +++ legacy binary: /Users/ggwp/Documents/Decentrio/cosmos-sdk/tests/systemtests/binaries/simd_v0.50
Setup chain: ./testnet
+++ /Users/ggwp/Documents/Decentrio/cosmos-sdk/tests/systemtests/binaries/simd_v0.50 testnet init-files --chain-id=testing --output-dir=./testnet --v=4 --keyring-backend=test --minimum-gas-prices=0.000001stake
--- FAIL: TestChainUpgrade (0.00s)
panic: run `/Users/ggwp/Documents/Decentrio/cosmos-sdk/tests/systemtests/binaries/simd_v0.50 testnet init-files --chain-id=testing --output-dir=./testnet --v=4 --keyring-backend=test --minimum-gas-prices=0.000001stake`: out: : fork/exec /Users/ggwp/Documents/Decentrio/cosmos-sdk/tests/systemtests/binaries/simd_v0.50: exec format error [recovered]
        panic: run `/Users/ggwp/Documents/Decentrio/cosmos-sdk/tests/systemtests/binaries/simd_v0.50 testnet init-files --chain-id=testing --output-dir=./testnet --v=4 --keyring-backend=test --minimum-gas-prices=0.000001stake`: out: : fork/exec /Users/ggwp/Documents/Decentrio/cosmos-sdk/tests/systemtests/binaries/simd_v0.50: exec format error

goroutine 23 [running]:
testing.tRunner.func1.2({0x101a70300, 0x1400075e300})
        /opt/homebrew/Cellar/go/1.23.2/libexec/src/testing/testing.go:1632 +0x1bc
testing.tRunner.func1()
        /opt/homebrew/Cellar/go/1.23.2/libexec/src/testing/testing.go:1635 +0x334
panic({0x101a70300?, 0x1400075e300?})
        /opt/homebrew/Cellar/go/1.23.2/libexec/src/runtime/panic.go:785 +0x124
cosmossdk.io/tests/systemtests.ModifyConfigYamlInitializer.Initialize({{0x140003b0dc0, 0x50}, {0x140000560c4, 0x3c}, {0x1015b41b8, 0x7}, {0x1015b748d, 0x9}, 0x4, {0x14000806050, ...}, ...})
        /Users/ggwp/Documents/Decentrio/cosmos-sdk/tests/systemtests/testnet_init.go:149 +0x774
cosmossdk.io/tests/systemtests.(*SystemUnderTest).SetupChain(0x1400080c120)
        /Users/ggwp/Documents/Decentrio/cosmos-sdk/tests/systemtests/system.go:125 +0xcc
cosmossdk.io/tests/systemtests.TestChainUpgrade(0x14000641d40)
        /Users/ggwp/Documents/Decentrio/cosmos-sdk/tests/systemtests/upgrade_test.go:32 +0x2d8
testing.tRunner(0x14000641d40, 0x101ce2058)
        /opt/homebrew/Cellar/go/1.23.2/libexec/src/testing/testing.go:1690 +0xe4
created by testing.(*T).Run in goroutine 1
        /opt/homebrew/Cellar/go/1.23.2/libexec/src/testing/testing.go:1743 +0x314
FAIL    cosmossdk.io/tests/systemtests  0.642s
FAIL

[julienrbrt]

I try to run in my local but still get the error in . Any idea? 👀

systemtests git:(alex/v0.52.x/22196_fix) go test -mod=readonly -tags='system_test' -v ./...  --run TestChainUpgrade --verbose
Work dir:  /Users/ggwp/Documents/Decentrio/cosmos-sdk/tests/systemtests
Setup chain: ./testnet
+++ /Users/ggwp/Documents/Decentrio/cosmos-sdk/tests/systemtests/binaries/simd testnet init-files --chain-id=testing --output-dir=./testnet --validator-count=4 --keyring-backend=test --commit-timeout=900ms --single-host --minimum-gas-prices=0.000001stake
=== RUN   TestChainUpgrade
Stop chain
    upgrade_test.go:27: +++ legacy binary: /Users/ggwp/Documents/Decentrio/cosmos-sdk/tests/systemtests/binaries/simd_v0.50
Setup chain: ./testnet
+++ /Users/ggwp/Documents/Decentrio/cosmos-sdk/tests/systemtests/binaries/simd_v0.50 testnet init-files --chain-id=testing --output-dir=./testnet --v=4 --keyring-backend=test --minimum-gas-prices=0.000001stake
--- FAIL: TestChainUpgrade (0.00s)
panic: run `/Users/ggwp/Documents/Decentrio/cosmos-sdk/tests/systemtests/binaries/simd_v0.50 testnet init-files --chain-id=testing --output-dir=./testnet --v=4 --keyring-backend=test --minimum-gas-prices=0.000001stake`: out: : fork/exec /Users/ggwp/Documents/Decentrio/cosmos-sdk/tests/systemtests/binaries/simd_v0.50: exec format error [recovered]
        panic: run `/Users/ggwp/Documents/Decentrio/cosmos-sdk/tests/systemtests/binaries/simd_v0.50 testnet init-files --chain-id=testing --output-dir=./testnet --v=4 --keyring-backend=test --minimum-gas-prices=0.000001stake`: out: : fork/exec /Users/ggwp/Documents/Decentrio/cosmos-sdk/tests/systemtests/binaries/simd_v0.50: exec format error

goroutine 23 [running]:
testing.tRunner.func1.2({0x101a70300, 0x1400075e300})
        /opt/homebrew/Cellar/go/1.23.2/libexec/src/testing/testing.go:1632 +0x1bc
testing.tRunner.func1()
        /opt/homebrew/Cellar/go/1.23.2/libexec/src/testing/testing.go:1635 +0x334
panic({0x101a70300?, 0x1400075e300?})
        /opt/homebrew/Cellar/go/1.23.2/libexec/src/runtime/panic.go:785 +0x124
cosmossdk.io/tests/systemtests.ModifyConfigYamlInitializer.Initialize({{0x140003b0dc0, 0x50}, {0x140000560c4, 0x3c}, {0x1015b41b8, 0x7}, {0x1015b748d, 0x9}, 0x4, {0x14000806050, ...}, ...})
        /Users/ggwp/Documents/Decentrio/cosmos-sdk/tests/systemtests/testnet_init.go:149 +0x774
cosmossdk.io/tests/systemtests.(*SystemUnderTest).SetupChain(0x1400080c120)
        /Users/ggwp/Documents/Decentrio/cosmos-sdk/tests/systemtests/system.go:125 +0xcc
cosmossdk.io/tests/systemtests.TestChainUpgrade(0x14000641d40)
        /Users/ggwp/Documents/Decentrio/cosmos-sdk/tests/systemtests/upgrade_test.go:32 +0x2d8
testing.tRunner(0x14000641d40, 0x101ce2058)
        /opt/homebrew/Cellar/go/1.23.2/libexec/src/testing/testing.go:1690 +0xe4
created by testing.(*T).Run in goroutine 1
        /opt/homebrew/Cellar/go/1.23.2/libexec/src/testing/testing.go:1743 +0x314
FAIL    cosmossdk.io/tests/systemtests  0.642s
FAIL

it's my bad, i thought it was fixed, but the test failed before this and not after (my search failed me), so this is indeed not resolved either (cc @alpe)

[hieuvubk]

yeah seem like TestTxWithFeePayer is blocking upgrade test

[alpe]

@hieuvubk the v0.50 binary is pulled from the docker image and works with Linux only. I removed the Go build tag unfortunately. That was wrong.
To run the test on Mac, you would to build a custom artifact and place it in the tests/systemtests/binaries folder with the correct name.