docs(x/accounts): improve comments #22339
Conversation
julienrbrt
added
the
backport/v0.52.x
julienrbrt
requested review from
a team,
testinginprod and
sontrinh16
as code owners
📝 Walkthrough📝 WalkthroughWalkthroughThe pull request introduces several modifications across multiple files related to the Cosmos SDK. Key changes include updates to comments in the lockup and multisig message definitions for clarity, the addition of new message types for multisig account functionalities, and enhancements to the README documentation for the x/accounts module. Additionally, the Changes
Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yml 📒 Files selected for processing (2)
🧰 Additional context used📓 Path-based instructions (1)
🔇 Additional comments (3)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (10)
x/accounts/README.md (5)
363-365: Include the actual protobuf definition instead of a reference link.For better readability and self-containment of the documentation, consider replacing the GitHub reference link with the actual protobuf definition of
MsgAuthenticate. This ensures that readers don't need to navigate to a different page to understand the interface.
362-365: Enhance authentication documentation with common patterns.Consider adding examples of common authentication patterns (e.g., multisig, time-based, threshold) to help developers understand how to implement secure authentication mechanisms.
Line range hint
566-567: Add more genesis configuration examples.Consider expanding the genesis section with examples for different account types to demonstrate the variety of initialization possibilities. This would help developers understand how to properly configure different types of accounts at genesis.
Line range hint
1-567: Maintain consistent capitalization for technical terms.Consider standardizing the capitalization of technical terms throughout the document. For example:
- "transaction (TX)" vs "Tx" vs "tx"
- "AnteHandler" vs "ante handler"
Line range hint
401-402: Enhance security considerations for authentication.Consider expanding the security considerations section with:
- Best practices for nonce management
- Signature verification guidelines
- Rate limiting recommendations
- Recovery mechanisms
api/cosmos/accounts/defaults/multisig/v1/multisig.pulsar.go (5)
8875-8878: Clarify the purpose of theMembersfield.The comment for the
Membersfield should provide more details on what constitutes a member of the multisig account and how they are used in the account's operations.
8877-8878: Clarify the purpose of theConfigfield.The comment for the
Configfield should provide more details on what configuration options are available for the multisig account and how they impact the account's behavior.
9280-9283: Provide more details in the comments for theThresholdandQuorumfields.The comments should clarify:
- How the
ThresholdandQuorumvalues are determined- What happens if the
Thresholdis not met- What happens if the
Quorumis not met- How these fields interact with the
Membersof the multisig account
9353-9362: Enhance the comments for theProposalstruct fields.The comments for the
Proposalstruct fields should provide more context on:
- Expectations for the
TitleandSummarycontent and length- What types of
Messagescan be included- How the
VotingPeriodEndis determined- Details on each of the possible
Statusvalues a proposal can have
9517-9520: Clarify the relationship betweenMembersandConfigin the response.The comment should specify if the
MembersandConfigreturned in theQueryConfigResponserepresent the current state of the multisig account. If they can be different from the current state, explain when and why that can occur.
📜 Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
⛔ Files ignored due to path filters (2)
x/accounts/defaults/lockup/v1/tx.pb.gois excluded by!**/*.pb.gox/accounts/defaults/multisig/v1/multisig.pb.gois excluded by!**/*.pb.go
📒 Files selected for processing (6)
- api/cosmos/accounts/defaults/lockup/v1/tx.pulsar.go (1 hunks)
- api/cosmos/accounts/defaults/multisig/v1/multisig.pulsar.go (4 hunks)
- simapp/go.mod (2 hunks)
- x/accounts/README.md (1 hunks)
- x/accounts/proto/cosmos/accounts/defaults/lockup/v1/tx.proto (7 hunks)
- x/accounts/proto/cosmos/accounts/defaults/multisig/v1/multisig.proto (4 hunks)
✅ Files skipped from review due to trivial changes (2)
- x/accounts/proto/cosmos/accounts/defaults/lockup/v1/tx.proto
- x/accounts/proto/cosmos/accounts/defaults/multisig/v1/multisig.proto
🧰 Additional context used
📓 Path-based instructions (3)
api/cosmos/accounts/defaults/lockup/v1/tx.pulsar.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.api/cosmos/accounts/defaults/multisig/v1/multisig.pulsar.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.x/accounts/README.md (1)
Pattern
**/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
🔇 Additional comments (3)
simapp/go.mod (2)
17-19: LGTM: Account module dependencies properly configuredThe new dependencies for base and multisig account defaults are correctly added with placeholder versions and corresponding replace directives for local development.
49-49: LGTM: Protobuf dependency properly configuredThe google.golang.org/protobuf dependency is correctly moved to active requirements with a pinned version v1.35.1.
api/cosmos/accounts/defaults/lockup/v1/tx.pulsar.go (1)
Line range hint
1-1: Generated code - skip detailed review.This is an auto-generated protobuf file with a "DO NOT EDIT" header. The changes should be reviewed in the source
.protofile instead.Let's verify the proto file changes:
#!/bin/bash # Description: Verify the documentation changes in the proto file # Test: Check if the proto file contains the updated field comments rg -A 2 'end_time|start_time' 'cosmos/accounts/defaults/lockup/v1/tx.proto'
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (11)
x/accounts/proto/cosmos/accounts/defaults/multisig/v1/multisig.proto (4)
12-15: Enhance field documentation with more contextWhile the comments are accurate, they could be more informative for developers implementing multisig accounts.
Consider expanding the comments like this:
- // members are the members of the multisig account. + // members defines the list of addresses and their corresponding voting weights + // that are authorized to manage this multisig account. repeated Member members = 1; - // config is the configuration of the multisig account. + // config specifies the voting rules and operational parameters + // that govern this multisig account's decision-making process. Config config = 2;
73-76: Clarify threshold and quorum definitionsThe current comments could be more precise about how these parameters affect voting outcomes.
Consider this improved documentation:
- // threshold is the minimum weight required for a proposal to pass. + // threshold specifies the minimum sum of member weights required for a proposal + // to pass. For example, if threshold is 7, the sum of weights of all 'yes' + // votes must be at least 7 for the proposal to pass. int64 threshold = 1; - // quorum is the minimum number of members that need to vote for a proposal to pass. + // quorum defines the minimum number of members that must vote (regardless of + // their vote option) for a proposal to be considered valid. This ensures + // sufficient participation in decision-making. int64 quorum = 2;
91-103: Expand proposal field documentationThe comments should provide more guidance on field usage and expectations.
Consider enhancing the documentation:
- // title is the title of the proposal. + // title is a brief, descriptive name for the proposal that uniquely identifies + // its purpose to multisig members. string title = 1; - // summary is the summary of the proposal. + // summary provides a detailed description of the proposal's intent, including + // the rationale for the proposed actions and expected outcomes. string summary = 2; - // status is the current status of the proposal. + // status tracks the proposal's current state in the voting process + // (unspecified, voting period, passed, or rejected). This field is managed + // by the system and should not be set during proposal creation. ProposalStatus status = 5;
121-124: Improve response field documentationThe comments should better describe the response context.
Consider this enhanced documentation:
- // members are the current members of the account. + // members returns the current list of authorized members and their respective + // voting weights for this multisig account at the time of query. repeated Member members = 1; - // config is the current config of the account. + // config returns the active voting rules and operational parameters that + // currently govern this multisig account's decision-making process. Config config = 2;x/accounts/proto/cosmos/accounts/defaults/lockup/v1/tx.proto (1)
Line range hint
86-96: Consider enhancing message documentationWhile the formatting is good, consider adding a more detailed description for the
MsgSendmessage, similar to other messages in the file. The description should explain when and why this message would be used in the context of a lockup account.+// MsgSend defines a message that enables the lockup account owner to send locked tokens +// to another address, subject to lockup constraints and vesting schedules. message MsgSend {x/accounts/README.md (4)
363-365: Include the actual MsgAuthenticate code instead of external reference.Rather than linking to an external source, consider including the actual protobuf definition in the documentation. This ensures the documentation remains self-contained and readers don't need to navigate away to understand the interface.
Replace the reference with the actual protobuf definition:
message MsgAuthenticate { // signer is the account that is trying to authenticate the transaction string signer = 1; // signature_data contains the signature data that needs to be verified bytes signature_data = 2; } message MsgAuthenticateResponse {}
Line range hint
391-402: Consider using a sequence diagram for better flow visualization.The current top-down graph, while informative, could be improved by using a sequence diagram to better illustrate the temporal flow of the authentication process.
Consider replacing with:
sequenceDiagram participant C as Client participant AH as AnteHandler participant AM as x/accounts Module participant A as Account C->>AH: Submit Transaction AH->>AH: Execute Signature Verification alt is x/accounts signer AH->>AM: Delegate Authentication AM->>A: MsgAuthenticate alt implements Authentication A-->>AM: Success/Failure else A-->>AM: Non-externally owned account end AM-->>AH: Authentication Result else AH->>AH: Continue Standard Verification end AH-->>C: Final Result
Line range hint
516-547: Enhance the Genesis section with a complete example.The current Genesis section could be improved in several ways:
- The CLI command example lacks concrete parameter values
- The JSON example uses placeholder values ("..")
- The section ends abruptly without explaining the expected outcome
Consider enhancing the section with:
- A concrete CLI command example:
simd tx accounts init lockup \ '{"owner":"cosmos1...", "end_time":"2024-12-31T23:59:59Z", "start_time":"2024-01-01T00:00:00Z"}' \ --from cosmos1... --genesis
- A complete JSON example with actual values:
{ "app_state": { "accounts": { "init_account_msgs": [ { "sender": "cosmos1xyz...", "account_type": "lockup", "message": { "@type": "cosmos.accounts.defaults.lockup.MsgInitLockupAccount", "owner": "cosmos1abc...", "end_time": "2024-12-31T23:59:59Z", "start_time": "2024-01-01T00:00:00Z" }, "funds": [ { "denom": "stake", "amount": "1000" } ] } ] } } }
- Add a section explaining the expected outcome:
After genesis, you can verify the account creation using: ```simd query accounts list-accounts``` The command should show the newly created lockup account with the specified parameters.
Line range hint
1-3: Add table of contents and improve cross-references.The documentation would benefit from:
- A table of contents at the beginning for easier navigation
- Cross-references between related sections (e.g., linking Authentication section from Account Constructor section)
Consider adding a table of contents after the introduction:
## Table of Contents 1. [Basics](#basics) - [Example Account Creation](#example-account-creation) - [State Isolation](#state-isolation) 2. [Account Implementation](#account-implementation) - [Init](#init) - [Execute Handlers](#execute-handlers) - [Query Handlers](#query-handlers) - [Account Constructor](#the-account-constructor) 3. [App Wiring](#app-wiring) 4. [Authentication](#the-authentication-interface) 5. [Genesis](#genesis)api/cosmos/accounts/defaults/lockup/v1/tx.pulsar.go (1)
5854-5864: Consider enhancing field comments for better clarity.The comments for
end_timeandstart_timefields could be more descriptive to better explain their purpose and constraints.Consider updating the comments to:
- // end_time is end of lockup + // end_time defines the timestamp when the lockup period ends and tokens become withdrawable - // start_time is start of lockup + // start_time defines the timestamp when the lockup period begins and tokens become lockedapi/cosmos/accounts/defaults/multisig/v1/multisig.pulsar.go (1)
Line range hint
1-9999: The multisig account architecture looks well-designed.The message structures follow good practices:
- Clear separation between initialization, proposal management, and configuration
- Proper use of protobuf types for serialization
- Well-defined enums for proposal status and vote options
- Comprehensive query interfaces for account state
However, consider adding rate limiting or gas costs for proposal creation to prevent spam attacks.
📜 Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
⛔ Files ignored due to path filters (2)
x/accounts/defaults/lockup/v1/tx.pb.gois excluded by!**/*.pb.gox/accounts/defaults/multisig/v1/multisig.pb.gois excluded by!**/*.pb.go
📒 Files selected for processing (6)
- api/cosmos/accounts/defaults/lockup/v1/tx.pulsar.go (1 hunks)
- api/cosmos/accounts/defaults/multisig/v1/multisig.pulsar.go (4 hunks)
- simapp/go.mod (2 hunks)
- x/accounts/README.md (1 hunks)
- x/accounts/proto/cosmos/accounts/defaults/lockup/v1/tx.proto (7 hunks)
- x/accounts/proto/cosmos/accounts/defaults/multisig/v1/multisig.proto (4 hunks)
🧰 Additional context used
📓 Path-based instructions (3)
api/cosmos/accounts/defaults/lockup/v1/tx.pulsar.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.api/cosmos/accounts/defaults/multisig/v1/multisig.pulsar.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.x/accounts/README.md (1)
Pattern
**/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
🔇 Additional comments (9)
x/accounts/proto/cosmos/accounts/defaults/lockup/v1/tx.proto (5)
15-27: Documentation improvements look good!The enhanced comments for
end_timeandstart_timefields provide better clarity about their purpose in the lockup account context. The message description accurately describes the purpose ofMsgInitLockupAccount.
53-55: Option formatting looks good!The formatting of options follows a consistent style and improves readability.
65-67: Option formatting is consistent!The formatting matches the style used in other messages, maintaining consistency throughout the file.
76-78: Option formatting maintains consistency!The formatting aligns with the established pattern in the file.
107-111: Documentation and formatting improvements look good!The message description clearly explains the purpose of
MsgWithdraw, and the option formatting maintains consistency with the rest of the file.simapp/go.mod (2)
17-17: LGTM: New account module dependencies.The addition of base and multisig account defaults modules aligns with the documentation improvements in the x/accounts module.
Also applies to: 19-19
49-49: LGTM: Protobuf dependency requirement.Moving google.golang.org/protobuf to active requirements is appropriate as it's needed for the protobuf message definitions in the accounts module.
api/cosmos/accounts/defaults/lockup/v1/tx.pulsar.go (1)
Line range hint
1-6000: Message definitions and validations look good.The protobuf message definitions are well-structured with proper validation tags, correct field types, and appropriate interfaces implementation. The generated code follows best practices for protobuf code generation.
api/cosmos/accounts/defaults/multisig/v1/multisig.pulsar.go (1)
8875-8878: Documentation improvements look good!The added comments are clear, descriptive and follow Go documentation standards. They provide good context about:
- Member fields and their purpose
- Configuration parameters and their effects
- Proposal structure and field usage
Also applies to: 9280-9283, 9353-9362, 9517-9520
| @@ -38,8 +33,7 @@ message MsgInitLockupAccountResponse {} | |||
| // MsgInitPeriodicLockingAccount defines a message that enables creating a periodic locking | |||
| // account. | |||
| message MsgInitPeriodicLockingAccount { | |||
| option (amino.name) = "cosmos-sdk/MsgInitPeriodLockupAccount"; | |||
|
|
|||
| option (amino.name) = "cosmos-sdk/MsgInitPeriodLockupAccount"; | |||
There was a problem hiding this comment.
Fix typo in amino name option
The amino name contains a typo: MsgInitPeriodLockupAccount should be MsgInitPeriodicLockupAccount to match the message name.
- option (amino.name) = "cosmos-sdk/MsgInitPeriodLockupAccount";
+ option (amino.name) = "cosmos-sdk/MsgInitPeriodicLockupAccount";📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| option (amino.name) = "cosmos-sdk/MsgInitPeriodLockupAccount"; | |
| option (amino.name) = "cosmos-sdk/MsgInitPeriodicLockupAccount"; |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (2)
x/accounts/defaults/lockup/TUTORIAL.md (2)
211-211: Improve command syntax clarity.The command syntax has been simplified by removing the
--from ownerflag, which is an improvement. However, consider adding a note about the expected output format to make it more user-friendly.Add a comment about the expected output format:
simd tx accounts query <account_address> <query-request-type-url> $querycontents +# The command returns the query result in JSON format
Line range hint
1-256: General documentation improvements needed.Several areas of the documentation could be enhanced for clarity and correctness:
- The JSON examples contain syntax errors (missing commas after amount fields)
- Inconsistent use of "continuous" vs "continous" (spelling)
- Some warning blocks could be more informative by explaining the consequences
Would you like me to provide specific fixes for these issues?
🧰 Tools
🪛 LanguageTool
[duplication] ~12-~12: Possible typo: you repeated a word
Context: ...n) * Send coins * Query * Query account info ...(ENGLISH_WORD_REPEAT_RULE)
🪛 Markdownlint
4-4: Expected: 4; Actual: 2
Unordered list indentation(MD007, ul-indent)
5-5: Expected: 4; Actual: 2
Unordered list indentation(MD007, ul-indent)
6-6: Expected: 4; Actual: 2
Unordered list indentation(MD007, ul-indent)
7-7: Expected: 8; Actual: 4
Unordered list indentation(MD007, ul-indent)
8-8: Expected: 8; Actual: 4
Unordered list indentation(MD007, ul-indent)
9-9: Expected: 8; Actual: 4
Unordered list indentation(MD007, ul-indent)
10-10: Expected: 8; Actual: 4
Unordered list indentation(MD007, ul-indent)
11-11: Expected: 8; Actual: 4
Unordered list indentation(MD007, ul-indent)
12-12: Expected: 4; Actual: 2
Unordered list indentation(MD007, ul-indent)
13-13: Expected: 8; Actual: 4
Unordered list indentation(MD007, ul-indent)
14-14: Expected: 8; Actual: 4
Unordered list indentation(MD007, ul-indent)
📜 Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
📒 Files selected for processing (1)
- x/accounts/defaults/lockup/TUTORIAL.md (2 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
x/accounts/defaults/lockup/TUTORIAL.md (1)
Pattern
**/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
🪛 LanguageTool
x/accounts/defaults/lockup/TUTORIAL.md
[duplication] ~12-~12: Possible typo: you repeated a word
Context: ...n) * Send coins * Query * Query account info ...(ENGLISH_WORD_REPEAT_RULE)
🪛 Markdownlint
x/accounts/defaults/lockup/TUTORIAL.md
4-4: Expected: 4; Actual: 2
Unordered list indentation(MD007, ul-indent)
5-5: Expected: 4; Actual: 2
Unordered list indentation(MD007, ul-indent)
6-6: Expected: 4; Actual: 2
Unordered list indentation(MD007, ul-indent)
7-7: Expected: 8; Actual: 4
Unordered list indentation(MD007, ul-indent)
8-8: Expected: 8; Actual: 4
Unordered list indentation(MD007, ul-indent)
9-9: Expected: 8; Actual: 4
Unordered list indentation(MD007, ul-indent)
10-10: Expected: 8; Actual: 4
Unordered list indentation(MD007, ul-indent)
11-11: Expected: 8; Actual: 4
Unordered list indentation(MD007, ul-indent)
12-12: Expected: 4; Actual: 2
Unordered list indentation(MD007, ul-indent)
| * [Using lockup account on Cosmos sdk](#using-lockup-account-on-cosmos-sdk) | ||
| * [Setup](#setup) | ||
| * [Init](#init) | ||
| * [Execution](#execution) | ||
| * [Delegate](#delegate) | ||
| * [Undelegate](#undelegate) | ||
| * [Withdraw reward](#withdraw-reward) | ||
| * [Withdraw unlocked token](#withdraw-unlocked-token) | ||
| * [Send coins](#send-coins) | ||
| * [Query](#query) | ||
| * [Query](#query) |
There was a problem hiding this comment.
Fix table of contents indentation for better readability.
The table of contents structure needs consistent indentation to properly reflect the document hierarchy.
Apply these changes to fix the indentation:
- * [Using lockup account on Cosmos sdk](#using-lockup-account-on-cosmos-sdk)
- * [Setup](#setup)
- * [Init](#init)
- * [Execution](#execution)
- * [Delegate](#delegate)
- * [Undelegate](#undelegate)
- * [Withdraw reward](#withdraw-reward)
- * [Withdraw unlocked token](#withdraw-unlocked-token)
- * [Send coins](#send-coins)
- * [Query](#query)
- * [Query account info](#query-account-info)
- * [Query periodic lockup account locking periods](#query-periodic-lockup-account-locking-periods)
+ * [Using lockup account on Cosmos sdk](#using-lockup-account-on-cosmos-sdk)
+ * [Setup](#setup)
+ * [Init](#init)
+ * [Execution](#execution)
+ * [Delegate](#delegate)
+ * [Undelegate](#undelegate)
+ * [Withdraw reward](#withdraw-reward)
+ * [Withdraw unlocked token](#withdraw-unlocked-token)
+ * [Send coins](#send-coins)
+ * [Query](#query)
+ * [Query account info](#query-account-info)
+ * [Query periodic lockup account locking periods](#query-periodic-lockup-account-locking-periods)Committable suggestion was skipped due to low confidence.
🧰 Tools
🪛 LanguageTool
[duplication] ~12-~12: Possible typo: you repeated a word
Context: ...n) * Send coins * Query * Query account info ...(ENGLISH_WORD_REPEAT_RULE)
🪛 Markdownlint
4-4: Expected: 4; Actual: 2
Unordered list indentation(MD007, ul-indent)
5-5: Expected: 4; Actual: 2
Unordered list indentation(MD007, ul-indent)
6-6: Expected: 4; Actual: 2
Unordered list indentation(MD007, ul-indent)
7-7: Expected: 8; Actual: 4
Unordered list indentation(MD007, ul-indent)
8-8: Expected: 8; Actual: 4
Unordered list indentation(MD007, ul-indent)
9-9: Expected: 8; Actual: 4
Unordered list indentation(MD007, ul-indent)
10-10: Expected: 8; Actual: 4
Unordered list indentation(MD007, ul-indent)
11-11: Expected: 8; Actual: 4
Unordered list indentation(MD007, ul-indent)
12-12: Expected: 4; Actual: 2
Unordered list indentation(MD007, ul-indent)
github-actions
bot
added
C:Confix
(cherry picked from commit 98be2b8) # Conflicts: # api/cosmos/accounts/defaults/lockup/v1/tx.pulsar.go # api/cosmos/accounts/defaults/multisig/v1/multisig.pulsar.go # server/v2/api/telemetry/config.go # simapp/go.mod
Co-authored-by: Julien Robert <[email protected]>
* main: (157 commits) feat(core): add ConfigMap type (#22361) test: migrate e2e/genutil to systemtest (#22325) feat(accounts): re-introduce bundler (#21562) feat(log): add slog-backed Logger type (#22347) fix(x/tx): add feePayer as signer (#22311) test: migrate e2e/baseapp to integration tests (#22357) test: add x/circuit system tests (#22331) test: migrate e2e/tx tests to systemtest (#22152) refactor(simdv2): allow non-comet server components (#22351) build(deps): Bump rtCamp/action-slack-notify from 2.3.1 to 2.3.2 (#22352) fix(server/v2): respect context cancellation in start command (#22346) chore(simdv2): allow overriding the --home flag (#22348) feat(server/v2): add SimulateWithState to AppManager (#22335) docs(x/accounts): improve comments (#22339) chore: remove unused local variables (#22340) test: x/accounts systemtests (#22320) chore(client): use command's configured output (#22334) perf(log): use sonic json lib (#22233) build(deps): bump x/tx (#22327) fix(x/accounts/lockup): fix proto path (#22319) ...
Description
Noticed while doing the workshop: https://github.com/julienrbrt/workshop-cosmos-sdk-cosmoverse-2024
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...
Summary by CodeRabbit
New Features
Documentation
Bug Fixes
Configuration Updates
localhost:1318tolocalhost:1327in configuration files.