Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: migrate e2e/group to system tests (backport #22278) #22286

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 16, 2024

Description

Closes: #22219


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:

  • confirmed ! in the type prefix if API or client breaking change

  • targeted the correct branch (see PR Targeting)

  • provided a link to the relevant issue or specification

  • reviewed "Files changed" and left comments if necessary

  • included the necessary unit and integration tests

  • added a changelog entry to CHANGELOG.md

  • updated the relevant documentation or specification, including comments for documenting Go code

  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

  • New Features

    • Introduced a new set of system tests for group commands, enhancing the testing of group creation, policies, and proposal functionalities within the blockchain application.
  • Bug Fixes

    • Removed outdated end-to-end test files that were no longer necessary, streamlining the testing process.

This is an automatic backport of pull request #22278 done by [Mergify](https://mergify.com).

@mergify mergify bot requested a review from a team as a code owner October 16, 2024 20:15
@akhilkumarpilli akhilkumarpilli enabled auto-merge (squash) October 17, 2024 05:12
@julienrbrt
Copy link
Member

Screenshot from 2024-10-17 08-28-50
@akhilkumarpilli could you check this?

@akhilkumarpilli
Copy link
Contributor

@akhilkumarpilli could you check this?

@julienrbrt it's just a log printed in tests for false test cases. TestChainUpgrade is failing and I think there is some issue with v0.50 testnet setup.

@julienrbrt
Copy link
Member

@akhilkumarpilli could you check this?

@julienrbrt it's just a log printed in tests for false test cases. TestChainUpgrade is failing and I think there is some issue with v0.50 testnet setup.

okay, thanks I wasn't sure. Yes TestChainUpgrade needs to be fixed on v0.52 branch (#22146 (comment))

@julienrbrt julienrbrt merged commit 40f7878 into release/v0.52.x Oct 17, 2024
71 of 73 checks passed
@julienrbrt julienrbrt deleted the mergify/bp/release/v0.52.x/pr-22278 branch October 17, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants