fix(x/auth): fix multi file tx reading when no new line in file #22227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienrbrt
requested review from
facundomedica,
testinginprod,
aaronc and
a team
as code owners
📝 Walkthrough📝 WalkthroughWalkthroughThe changes in this pull request focus on modifying the Changes
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
julienrbrt
added
backport/v0.47.x
|
@julienrbrt your pull request is missing a changelog! |
|
I'll put a changelog in the v0.50 backport |
|
It looks like the minifier that I used my removing the tailing newline on the json. |
julienrbrt
changed the title
tac0turtle
approved these changes
Oct 11, 2024
julienrbrt
removed
the
backport/v0.47.x
facundomedica
approved these changes
Oct 11, 2024
|
It looks like it is unexpectedly breaking other behavior. Will keep as is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Step to repro:
Create a bank1.json and bank2.json file without a trailing new line.
$ simdv2 tx sign-batch bank1.json bank2.json --from alice {"body":{"messages":[{"@type":"/cosmos.bank.v1beta1.MsgSend","from_address":"cosmos1320u6jmp4k72947p84zfqyg22vy3vpe5ddnw2k","to_address":"cosmos1cyhshu4we258wcmlmjfw8zkkhhzcvgtx965seq","amount":[{"denom":"stake","amount":"100"}]},{"@type":"/cosmos.bank.v1beta1.MsgSend","from_address":"cosmos1320u6jmp4k72947p84zfqyg22vy3vpe5ddnw2k","to_address":"cosmos1cyhshu4we258wcmlmjfw8zkkhhzcvgtx965seq","amount":[{"denom":"stake","amount":"4"}]}],"memo":"","timeout_height":"0","unordered":false,"timeout_timestamp":"0001-01-01T00:00:00Z","extension_options":[],"non_critical_extension_options":[]},"auth_info":{"signer_infos":[{"public_key":{"@type":"/cosmos.crypto.secp256k1.PubKey","key":"AhDC1ZXMhxwKI75/n9x8jhXSI6Eo3ycS8J061YYruipm"},"mode_info":{"single":{"mode":"SIGN_MODE_DIRECT"}},"sequence":"8"}],"fee":{"amount":[],"gas_limit":"200000","payer":"cosmos1320u6jmp4k72947p84zfqyg22vy3vpe5ddnw2k","granter":""},"tip":null},"signatures":["otcHOgJHwdEziYpQifZf12CQrUM0KIxTdmKd0OK713AeID1/gVup2IFNvpEYcJBttasar3WtSdHzGgEZmLYYvA=="]}After
$simdv2 tx sign-batch bank1.json bank2.json --from alice {"body":{"messages":[{"@type":"/cosmos.bank.v1beta1.MsgSend","from_address":"cosmos1320u6jmp4k72947p84zfqyg22vy3vpe5ddnw2k","to_address":"cosmos1cyhshu4we258wcmlmjfw8zkkhhzcvgtx965seq","amount":[{"denom":"stake","amount":"100"}]},{"@type":"/cosmos.bank.v1beta1.MsgSend","from_address":"cosmos1320u6jmp4k72947p84zfqyg22vy3vpe5ddnw2k","to_address":"cosmos1cyhshu4we258wcmlmjfw8zkkhhzcvgtx965seq","amount":[{"denom":"stake","amount":"4"}]}],"memo":"","timeout_height":"0","unordered":false,"timeout_timestamp":"0001-01-01T00:00:00Z","extension_options":[],"non_critical_extension_options":[]},"auth_info":{"signer_infos":[{"public_key":{"@type":"/cosmos.crypto.secp256k1.PubKey","key":"AhDC1ZXMhxwKI75/n9x8jhXSI6Eo3ycS8J061YYruipm"},"mode_info":{"single":{"mode":"SIGN_MODE_DIRECT"}},"sequence":"8"}],"fee":{"amount":[],"gas_limit":"200000","payer":"cosmos1320u6jmp4k72947p84zfqyg22vy3vpe5ddnw2k","granter":""},"tip":null},"signatures":["otcHOgJHwdEziYpQifZf12CQrUM0KIxTdmKd0OK713AeID1/gVup2IFNvpEYcJBttasar3WtSdHzGgEZmLYYvA=="]} {"body":{"messages":[{"@type":"/cosmos.bank.v1beta1.MsgSend","from_address":"cosmos1320u6jmp4k72947p84zfqyg22vy3vpe5ddnw2k","to_address":"cosmos1cyhshu4we258wcmlmjfw8zkkhhzcvgtx965seq","amount":[{"denom":"stake","amount":"10"}]},{"@type":"/cosmos.bank.v1beta1.MsgSend","from_address":"cosmos1320u6jmp4k72947p84zfqyg22vy3vpe5ddnw2k","to_address":"cosmos1cyhshu4we258wcmlmjfw8zkkhhzcvgtx965seq","amount":[{"denom":"stake","amount":"2"}]}],"memo":"","timeout_height":"0","unordered":false,"timeout_timestamp":"0001-01-01T00:00:00Z","extension_options":[],"non_critical_extension_options":[]},"auth_info":{"signer_infos":[{"public_key":{"@type":"/cosmos.crypto.secp256k1.PubKey","key":"AhDC1ZXMhxwKI75/n9x8jhXSI6Eo3ycS8J061YYruipm"},"mode_info":{"single":{"mode":"SIGN_MODE_DIRECT"}},"sequence":"9"}],"fee":{"amount":[],"gas_limit":"200000","payer":"cosmos1320u6jmp4k72947p84zfqyg22vy3vpe5ddnw2k","granter":""},"tip":null},"signatures":["eLbYi3gekpdmG4cQ5lTARoLHIcx3fJL+0Wpr7yvff5EEehQh4jnjOQD1vAp0AxeufVyb6MlfwHTIRcA8sN4NZQ=="]}Found while reviewing #22149
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...
Summary by CodeRabbit
Summary by CodeRabbit
New Features
Bug Fixes