feat(tools/cosmovisor): pass stdin to process #21462
Conversation
WalkthroughWalkthroughThe changes to the Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
tools/cosmovisor/CHANGELOG.md (1)
49-52: Fix unordered list indentation.The unordered list indentation is inconsistent. Apply this diff to fix the indentation:
- * `init command` writes the configuration to the config file only at the default path `DAEMON_HOME/cosmovisor/config.toml`. - * Provide `--cosmovisor-config` flag with value as args to provide the path to the configuration file in the `run` command. `run --cosmovisor-config <path> (other cmds with flags) ...`. - * Add `--cosmovisor-config` flag to provide `config.toml` path to the configuration file in root command used by `add-upgrade` and `config` subcommands. - * `config command` now displays the configuration from the config file if it is provided. If the config file is not provided, it will display the configuration from the environment variables. + * `init command` writes the configuration to the config file only at the default path `DAEMON_HOME/cosmovisor/config.toml`. + * Provide `--cosmovisor-config` flag with value as args to provide the path to the configuration file in the `run` command. `run --cosmovisor-config <path> (other cmds with flags) ...`. + * Add `--cosmovisor-config` flag to provide `config.toml` path to the configuration file in root command used by `add-upgrade` and `config` subcommands. + * `config command` now displays the configuration from the config file if it is provided. If the config file is not provided, it will display the configuration from the environment variables.Tools
Markdownlint
49-49: Expected: 4; Actual: 2
Unordered list indentation(MD007, ul-indent)
50-50: Expected: 4; Actual: 2
Unordered list indentation(MD007, ul-indent)
51-51: Expected: 4; Actual: 2
Unordered list indentation(MD007, ul-indent)
52-52: Expected: 4; Actual: 2
Unordered list indentation(MD007, ul-indent)
Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files selected for processing (5)
- tools/cosmovisor/CHANGELOG.md (1 hunks)
- tools/cosmovisor/cmd/cosmovisor/run.go (1 hunks)
- tools/cosmovisor/cmd/cosmovisor/run_config.go (1 hunks)
- tools/cosmovisor/process.go (2 hunks)
- tools/cosmovisor/process_test.go (19 hunks)
Additional context used
Path-based instructions (5)
tools/cosmovisor/cmd/cosmovisor/run_config.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.tools/cosmovisor/cmd/cosmovisor/run.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.tools/cosmovisor/CHANGELOG.md (1)
Pattern
**/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"tools/cosmovisor/process.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.tools/cosmovisor/process_test.go (2)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
Pattern
**/*_test.go: "Assess the unit test code assessing sufficient code coverage for the changes associated in the pull request"
Markdownlint
tools/cosmovisor/CHANGELOG.md
49-49: Expected: 4; Actual: 2
Unordered list indentation(MD007, ul-indent)
50-50: Expected: 4; Actual: 2
Unordered list indentation(MD007, ul-indent)
51-51: Expected: 4; Actual: 2
Unordered list indentation(MD007, ul-indent)
52-52: Expected: 4; Actual: 2
Unordered list indentation(MD007, ul-indent)
Additional comments not posted (13)
tools/cosmovisor/cmd/cosmovisor/run_config.go (3)
10-12: LGTM!The code changes are approved.
17-19: LGTM!The code changes are approved.
24-29: LGTM!The code changes are approved.
tools/cosmovisor/cmd/cosmovisor/run.go (2)
48-48: LGTM!The code changes are approved.
52-52: LGTM!The code changes are approved.
tools/cosmovisor/CHANGELOG.md (1)
39-42: LGTM!The documentation change is approved.
tools/cosmovisor/process.go (1)
Line range hint
42-54: LGTM! But verify the function usage in the codebase.The function is correctly implemented. However, ensure that all function calls to
Launcher.Runmatch the new signature.The code changes are approved.
Run the following script to verify the function usage:
tools/cosmovisor/process_test.go (6)
Line range hint
32-44: LGTM!The changes to the
TestLaunchProcessfunction are correctly implemented.Also applies to: 59-59
Line range hint
77-89: LGTM!The changes to the
TestPlanDisableRecasefunction are correctly implemented.Also applies to: 104-104
Line range hint
121-133: LGTM!The changes to the
TestLaunchProcessWithRestartDelayfunction are correctly implemented.
Line range hint
152-164: LGTM!The changes to the
TestPlanShutdownGracefunction are correctly implemented.Also applies to: 179-179
209-212: LGTM!The changes to the
TestLaunchProcessWithDownloadsfunction are correctly implemented.Also applies to: 225-225, 240-240
279-282: LGTM!The changes to the
TestLaunchProcessWithDownloadsAndPreupgradefunction are correctly implemented.Also applies to: 315-318, 335-335, 353-353
Description
Closes: #17053
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...
Summary by CodeRabbit
New Features
cosmovisortool, allowing users to specify alternative configuration file paths.stdin) to improve input handling flexibility during command execution.Bug Fixes
Tests
launcher.Runmethod.