Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: Governance CLI uses Querier #2141

Merged
merged 2 commits into from
Aug 28, 2018
Merged

R4R: Governance CLI uses Querier #2141

merged 2 commits into from
Aug 28, 2018

Conversation

sunnya97
Copy link
Member

@sunnya97 sunnya97 commented Aug 24, 2018

closes #2125

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@sunnya97 sunnya97 changed the title Governance CLI uses Querier WIP: Governance CLI uses Querier Aug 24, 2018
@sunnya97 sunnya97 changed the title WIP: Governance CLI uses Querier R4R: Governance CLI uses Querier Aug 27, 2018
@codecov
Copy link

codecov bot commented Aug 27, 2018

Codecov Report

❗ No coverage uploaded for pull request base (develop@5128a7c). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop    #2141   +/-   ##
==========================================
  Coverage           ?   63.91%           
==========================================
  Files              ?      134           
  Lines              ?     8194           
  Branches           ?        0           
==========================================
  Hits               ?     5237           
  Misses             ?     2604           
  Partials           ?      353

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, thanks!

Could add a changelog entry but the existing one encapsulates this already.

@cwgoes cwgoes merged commit d1ecc8f into develop Aug 28, 2018
@cwgoes cwgoes deleted the sunny/gov-cli-querier branch August 28, 2018 12:50
@cwgoes
Copy link
Contributor

cwgoes commented Sep 3, 2018

Ref discussion in #2139 (comment), which also applies to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update gov CLI to use Querier
2 participants