fix: reimplement sig verification for app v2 (backport #21386)

[mergify]

Description

• makes x/auth/tx an actual app module, which currently just contains a ValidateTx method
• TestStakeUnstake has a small change that we need to remove once we fix the fee decorator + skipping the UnorderedTx test for now
• Changed the gas meter type in SignatureVerificationGasConsumer for core gas.Meter
• Fixed issue in the account retriever that caused issues when queries were routed through CometBFT (not sure the details on this one)

I also removed the usages of !ctx.IsSigverifyTx(), I'm unsure of the impact of this handling it optionally now, only if context is an sdk.Context, otherwise we'll always verify the signature

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title, you can find examples of the prefixes below:

• confirmed ! in the type prefix if API or client breaking change

• targeted the correct branch (see PR Targeting)

• provided a link to the relevant issue or specification

• reviewed "Files changed" and left comments if necessary

• included the necessary unit and integration tests

• added a changelog entry to CHANGELOG.md

• updated the relevant documentation or specification, including comments for documenting Go code

• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

• confirmed the correct type prefix in the PR title
• confirmed all author checklist items have been addressed
• reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

• Bug Fixes

  • Enhanced error handling in account retrieval to manage potential wrapped errors effectively.

• Tests

  • Updated balance assertion in staking tests to reflect expected changes due to upcoming fee modifications.
  • Disabled a test for duplicate transactions to indicate it is currently incomplete or not applicable.
  • Improved gas consumption testing for signature verification processes using a new mock gas meter.
  • Enhanced context setup in testing to include blockchain header information.

• New Features

  • Improved transaction handling architecture with new modules for enhanced signature verification and validation processes.
  • Updated build and environment configurations to support versioning changes.
  • Introduced mock implementations for service and meter interfaces to enhance testing capabilities.

---

This is an automatic backport of pull request #21386 done by [Mergify](https://mergify.com).

[mergify]

Cherry-pick of 7c85b98 has failed:

On branch mergify/bp/release/v0.52.x/pr-21386
Your branch is up to date with 'origin/release/v0.52.x'.

You are currently cherry-picking commit 7c85b981c.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   core/testing/gas/service_mocks.go
	modified:   scripts/init-simapp-v2.sh
	modified:   scripts/mockgen.sh
	modified:   simapp/simd/cmd/testnet_test.go
	modified:   tests/systemtests/cli.go
	modified:   tests/systemtests/staking_test.go
	modified:   tests/systemtests/unordered_tx_test.go
	modified:   x/auth/ante/ante.go
	modified:   x/auth/ante/ante_test.go
	modified:   x/auth/ante/sigverify.go
	modified:   x/auth/ante/sigverify_test.go
	modified:   x/auth/ante/testutil_test.go
	modified:   x/auth/tx/config/depinject.go
	modified:   x/auth/types/account_retriever.go

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   core/testing/go.mod
	deleted by us:   core/testing/go.sum

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Base branches to auto review (1)

• main

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

@mergify[bot] your pull request is missing a changelog!